Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_express_route_circuit_connection #11303

Merged
merged 31 commits into from
Jun 30, 2021
Merged

New resource azurerm_express_route_circuit_connection #11303

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c85c7f7
new resource express route circuit connection
Mar 22, 2021
f18a701
new resource express route circuit connection
Apr 12, 2021
3ac150b
* remove peering_name
Apr 13, 2021
7c390c7
format
Apr 13, 2021
7275014
format
Apr 13, 2021
1768c01
remove unused params
Apr 13, 2021
39b00d2
update code
Apr 16, 2021
116abdc
update code
Apr 19, 2021
78614df
update code
Apr 19, 2021
32ad561
update code
Apr 19, 2021
4eba331
update code
Apr 19, 2021
a819345
update code
Apr 20, 2021
10409c6
update code
Jun 15, 2021
c17b006
Merge remote-tracking branch 'upstream/master' into f/expressroutecir…
Jun 15, 2021
84da756
update code
Jun 15, 2021
68b4113
update code
Jun 15, 2021
3f1ae94
update code
Jun 17, 2021
8082518
update code
Jun 17, 2021
1e9b435
update code
Jun 18, 2021
b887d31
Merge remote-tracking branch 'upstream/master' into f/expressroutecir…
Jun 25, 2021
00028bc
update code
Jun 25, 2021
7e8910c
update code
Jun 25, 2021
1b344e2
update code
Jun 26, 2021
3163083
update code
Jun 26, 2021
9298a2d
update code
Jun 26, 2021
2b23456
update code
Jun 26, 2021
3e9557b
update code
Jun 30, 2021
e91a70c
update code
Jun 30, 2021
b174375
update code
Jun 30, 2021
49dd452
update code
Jun 30, 2021
7960a66
update code
Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion azurerm/internal/services/network/express_route_circuit_connection_resource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,8 +186,10 @@ func resourceExpressRouteCircuitConnectionRead(d *pluginsdk.ResourceData, meta i
if props := resp.ExpressRouteCircuitConnectionPropertiesFormat; props != nil {
d.Set("address_prefix_ipv4", props.AddressPrefix)

// The ExpressRoute Circuit Connection API returns "*****************" for AuthorizationKey when it's changed from a valid value to `nil`
// See more details from https://github.com/Azure/azure-rest-api-specs/issues/15030
authorizationKey := ""
if props.AuthorizationKey != nil {
if props.AuthorizationKey != nil && *props.AuthorizationKey != "*****************" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we ignore those invalid value to be specified at the first place?

Copy link
Contributor

@neil-yechenwei neil-yechenwei Jun 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot ignore it at the beginning. Because "*****************" is returned only when authorizationKey is changed from "xxxxx" to nil.

Scenario 1:
when authorizationKey isn't specified in tf, api returns nil

Scenario 2:
When authorizationKey is specified in tf, api returns "xxxxx"

Scenario 3:
When authorizationKey is changed from "xxxx" to nil in tf, api returns "*****************"

authorizationKey = *props.AuthorizationKey
}
d.Set("authorization_key", authorizationKey)
Expand Down