Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add open service mesh option for kuberentes service (public preview) #11189

Closed

Conversation

@ghost ghost added the size/M label Apr 1, 2021
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @yershalom

Thanks for this PR - taking a look through on the whole this looks pretty good to me, but can we add some documentation for these new fields so that users are able to find them?

Thanks!

@ghost ghost added size/L documentation and removed size/M labels Apr 7, 2021
@yershalom yershalom requested a review from tombuildsstuff April 7, 2021 12:55
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @yershalom

Thanks for pushing those changes, I've taken a look through and left a few more comments inline, but if we can fix those up (and the tests pass) then this should be good to go 👍

Thanks!

azurerm/internal/services/containers/kubernetes_addons.go Outdated Show resolved Hide resolved
"enabled": {
Type: schema.TypeBool,
Required: true,
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

},
},
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll also need to flatten this value for the Data Source, this is done in flattenKubernetesClusterDataSourceAddonProfiles (by parsing the add-on profile from the response and reading the enabled state)

per tombuildsstuff review

Co-authored-by: Tom Harvey <[email protected]>
@katbyte
Copy link
Collaborator

katbyte commented May 4, 2021

Hey @yershalom - just wondering if your still working on this 🙂

@yershalom
Copy link
Author

Hi @katbyte , yes, I have a lot of pressure now but I will fix the comment and conflicts when I'll have time :-)

@ghost ghost removed the waiting-response label May 4, 2021
@katbyte
Copy link
Collaborator

katbyte commented Jun 11, 2021

hey @yershalom - i'm going to close this for now as its been a month and the branch is getting out of date/conflicted - please do reopen this once you've had time to address the reviews - thanks again!

@katbyte katbyte closed this Jun 11, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants