Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource: azurerm_purview_account #10395

Merged
merged 18 commits into from
Mar 11, 2021

Conversation

allantargino
Copy link
Contributor

fixes #10358
depends on #10393

@ghost ghost added the size/XL label Jan 31, 2021
@ghost ghost added size/XXL dependencies and removed size/XL labels Feb 15, 2021
@ghost ghost added the documentation label Feb 15, 2021
@allantargino allantargino changed the title [WIP] New resource: Purview New resource: Purview Feb 15, 2021
@allantargino allantargino marked this pull request as ready for review February 15, 2021 13:52
@allantargino allantargino changed the title New resource: Purview New resource: azurerm_purview_account Feb 15, 2021
@allantargino
Copy link
Contributor Author

@katbyte @tombuildsstuff I would appreciate whenever you are free to do a review on this PR 😄 Thanks!

@allantargino
Copy link
Contributor Author

Hey @katbyte @tombuildsstuff @mbfrahry, would you please take a look on this PR? Thank you!

@favoretti favoretti requested a review from tombuildsstuff March 9, 2021 07:29
Copy link
Collaborator

@favoretti favoretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @allantargino, thank you for this PR. Looking mostly good to me, if we could address some minor issues, we should be able to get this over the finish line.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allantargino - overall this looks good, i've left some comments inline that once addressed this should be good to merge

@katbyte katbyte added this to the v2.51.0 milestone Mar 9, 2021
@allantargino
Copy link
Contributor Author

Thanks @katbyte, I just iterated over your comments :)

@allantargino allantargino requested a review from katbyte March 10, 2021 22:06
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @allantargino - this LGTM 👍

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @allantargino

Thanks for pushing those changes - taking a look through I've left some comments inline but this should otherwise be good to go - so that we can ship this in today's release I hope you don't mind but I'm going to push a commit to fix these comments 👍

Thanks!

@tombuildsstuff
Copy link
Contributor

Tests pass:

Screenshot 2021-03-11 at 12 41 55

@tombuildsstuff tombuildsstuff merged commit 02b5e9d into hashicorp:master Mar 11, 2021
tombuildsstuff added a commit that referenced this pull request Mar 11, 2021
@allantargino
Copy link
Contributor Author

allantargino commented Mar 11, 2021

Hi @tombuildsstuff, I've always learned so much from reviews like this :)
I highly appreciate it! Thank you so much!

@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.51.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Apr 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2021
@allantargino allantargino deleted the purview branch April 27, 2021 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Purview
4 participants