-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: azurerm_purview_account #10395
Conversation
@katbyte @tombuildsstuff I would appreciate whenever you are free to do a review on this PR 😄 Thanks! |
Hey @katbyte @tombuildsstuff @mbfrahry, would you please take a look on this PR? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @allantargino, thank you for this PR. Looking mostly good to me, if we could address some minor issues, we should be able to get this over the finish line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allantargino - overall this looks good, i've left some comments inline that once addressed this should be good to merge
Co-authored-by: kt <[email protected]>
Thanks @katbyte, I just iterated over your comments :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @allantargino - this LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @allantargino
Thanks for pushing those changes - taking a look through I've left some comments inline but this should otherwise be good to go - so that we can ship this in today's release I hope you don't mind but I'm going to push a commit to fix these comments 👍
Thanks!
Hi @tombuildsstuff, I've always learned so much from reviews like this :) |
This has been released in version 2.51.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.51.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
fixes #10358
depends on #10393