Add support ipv6 configuration in azurerm_express_route_circuit_peering #9235
Conversation
…cuitpeering_enhance
* document update
azurerm/internal/services/network/express_route_circuit_peering_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/tests/express_route_circuit_peering_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/express_route_circuit_peering_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/network/express_route_circuit_peering_resource.go
Outdated
Show resolved
Hide resolved
| SecondaryPeerAddressPrefix: utils.String(v["secondary_peer_address_prefix"].(string)), | ||
| MicrosoftPeeringConfig: expandExpressRouteCircuitPeeringMicrosoftConfig(v["microsoft_peering_config"].([]interface{})), | ||
| } | ||
| routeFilterId := v["route_filter_id"].(string) |
There was a problem hiding this comment.
could we add validation to check this is not set when incompatible types are used?
There was a problem hiding this comment.
I don't see a check for this anywhere?
There was a problem hiding this comment.
I don't know why GitHub does not display the latest code. I have add a check for routeFilterId . https://github.com/xuzhang3/terraform-provider-azurerm/blob/f/expressroutecircuitpeering_enhance/azurerm/internal/services/network/express_route_circuit_peering_resource.go#L400
There was a problem hiding this comment.
I still don't see a check to make sure route filter id is not set when type is microsoft in that link..
There was a problem hiding this comment.
ipv6 is a little different with microsoft_peering_config, it is only supported by MicrosoftPeering. I add a check for ipv6 not route_filter_id, if peering type is not MicrosoftPeering and ipv6 is configured, an error message will raise up.
Check ipv6 configure:
https://github.com/xuzhang3/terraform-provider-azurerm/blob/f/expressroutecircuitpeering_enhance/azurerm/internal/services/network/express_route_circuit_peering_resource.go#L267
| SecondaryPeerAddressPrefix: utils.String(v["secondary_peer_address_prefix"].(string)), | ||
| MicrosoftPeeringConfig: expandExpressRouteCircuitPeeringMicrosoftConfig(v["microsoft_peering_config"].([]interface{})), | ||
| } | ||
| routeFilterId := v["route_filter_id"].(string) |
There was a problem hiding this comment.
I don't see a check for this anywhere?
| SecondaryPeerAddressPrefix: utils.String(v["secondary_peer_address_prefix"].(string)), | ||
| MicrosoftPeeringConfig: expandExpressRouteCircuitPeeringMicrosoftConfig(v["microsoft_peering_config"].([]interface{})), | ||
| } | ||
| routeFilterId := v["route_filter_id"].(string) |
There was a problem hiding this comment.
I still don't see a check to make sure route filter id is not set when type is microsoft in that link..
|
This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.38.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
AccTests Result:
