Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for not being forced to stay with the initial name of the default_node_pool in azurerm_kubernetes_cluster #8493

Closed
timdeluxe opened this issue Sep 16, 2020 · 2 comments · Fixed by #8503

Comments

@timdeluxe
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In azurerm_kubernetes_cluster it is required to provide the configuration of a default_node_pool including a name. But one has to stay forever with that name, because this happened:

  • added a new nodepool with aks cli
  • migrated all pods to new nodepool by draining nodes of initial nodepool
  • changing mode of new nodepool to system and initial nodepool to user
  • deleted initial nodepool
  • (aks is absolutely happy at this point)
  • changed terraform code to give the "default_node_pool" the name of the new nodepool by changing the value of parameter "name"
  • ran terraform and got this Error: flattening `default_node_pool`: The Default Agent Pool "default" was not found

So i was forced to create a further nodepool named "default" and move all pods again (and the rest of the steps), just to make terraform happy. This is somewhat crazy.

New or Affected Resource(s)

  • azurerm_kubernetes_cluster

Potential Terraform Configuration

Note: I do not expect code to be changed. It is fine. I understand that the default_node_pool needs to be there (found explanation here: #7686 (comment)). But i would like terraform to respect the change of its name, which happened outside of terraform.

References

@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 21, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants