New resource azurerm_mysql_server_key - Add CMK support
#8125
Conversation
There was a problem hiding this comment.
hey @ArcturusZhang
Thanks for this PR 👍
I've taken a look through and left some comments inline but this is looking good - if we can work through those then we should be able to take another look 👍
Thanks!
| @@ -24,6 +24,10 @@ import ( | |||
| "github.com/terraform-providers/terraform-provider-azurerm/azurerm/utils" | |||
| ) | |||
|
|
|||
| const ( | |||
| mySQLServerResourceName = "azurerm_mysql_server" | |||
| ) | |||
There was a problem hiding this comment.
presumably we'll also need to lock in the create/update/delete here too?
There was a problem hiding this comment.
I assume we do not need locks in postgresql server.
This key resource has a kind of weird behaviour - it is a separated resource from the server by service design, but it is a singleton, you could only have one key at one time. If you are trying to create two keys (with different name) for one server, after the second key is created on the service side, the first key will be automatically removed without any notice.
Therefore we need locks in the server key resource to ensure that if the user is not using this resource correctly (by say create two keys for one server), the order of key creation is predictable - this will always give the user a diff after apply.
The server does not have this kind of constraint, therefore I suppose the server resource does not need locks.
There was a problem hiding this comment.
so what happens if you try and decrypt the server and delete it simultaneously? a conflict will likely occur somewhere?
There was a problem hiding this comment.
By decrypting the server, I assume we are deleting the server key - since we locked the server in the delete function of server key resource, we could not decrypt the server and delete it simultaneously - during the decrypting, the server is locked and deletion should hold on.
There was a problem hiding this comment.
can we test this to confirm?
There was a problem hiding this comment.
@ArcturusZhang any update here?
There was a problem hiding this comment.
Tests have been done per requested.
|
Hi @tombuildsstuff I have made some changes, please have a look, thanks |
|
This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.29.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Adding customer managed key support for mySQL server