Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New data source azurerm_mssql_server and new block restorable_dropped_databases in azuerrm_mssql_server #7917

Merged
merged 13 commits into from
Sep 21, 2020
Merged

New data source azurerm_mssql_server and new block restorable_dropped_databases in azuerrm_mssql_server #7917

merged 13 commits into from
Sep 21, 2020

Conversation

yupwei68
Copy link
Contributor

Fix #6502
#7594

=== RUN TestAccAzureRMMsSqlDatabase_createRestoreMode
=== PAUSE TestAccAzureRMMsSqlDatabase_createRestoreMode
=== CONT TestAccAzureRMMsSqlDatabase_createRestoreMode
--- PASS: TestAccAzureRMMsSqlDatabase_createRestoreMode (2016.02s)

Sql server listing recoverableDatabases Api has problems, thus it's excluded in the PR: Azure/azure-rest-api-specs#10162

@yupwei68 yupwei68 closed this Jul 28, 2020
@yupwei68 yupwei68 reopened this Jul 28, 2020
katbyte
katbyte requested changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yupwei68 - i've left some comments inline that need to be addressed before merge

website/docs/d/mssql_server.html.markdown Outdated Show resolved Hide resolved
website/docs/d/mssql_server.html.markdown Outdated Show resolved Hide resolved
website/docs/d/mssql_server.html.markdown Outdated Show resolved Hide resolved
website/docs/r/mssql_server.html.markdown Outdated Show resolved Hide resolved
website/docs/d/mssql_server.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
@katbyte katbyte added service/mssql Microsoft SQL Server waiting-response labels Sep 11, 2020
@katbyte katbyte added this to the v2.28.0 milestone Sep 11, 2020
@yupwei68
Copy link
Contributor Author

Hi @katbyte Thanks for your comments. I've replied the unchanged comments, others have been pushed. Please continue reviewing.

@ghost ghost removed the waiting-response label Sep 14, 2020
@yupwei68 yupwei68 requested a review from katbyte September 15, 2020 02:05
@yupwei68
Copy link
Contributor Author

Hi @katbyte Thanks for your comments. Changes have been pushed. Please continue reviewing.

@yupwei68
Copy link
Contributor Author

@katbyte Sorry for the mistakes. Please continue reviewing.

@yupwei68 yupwei68 requested a review from katbyte September 17, 2020 00:54
jackofallops
jackofallops requested changes Sep 17, 2020
View reviewed changes
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yupwei68
A couple of additional comments below. And apologies for re-opening the discussion on the property name, I'll try to catch up with @katbyte offline later today on that one.

Thanks

azurerm/internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_server_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_server_data_source.go Outdated Show resolved Hide resolved
@jackofallops jackofallops modified the milestones: v2.28.0, v2.29.0 Sep 17, 2020
yupwei68 added 2 commits September 18, 2020 16:21
katbyte
katbyte requested changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yupwei68 - as i have mentioned before, could we update the property names as suggested? thank you

azurerm/internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_database_resource.go Outdated Show resolved Hide resolved
katbyte
katbyte requested changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments from a second pass

website/docs/r/mssql_database.html.markdown Outdated Show resolved Hide resolved
website/docs/r/mssql_database.html.markdown Outdated Show resolved Hide resolved
website/docs/d/mssql_server.html.markdown Outdated Show resolved Hide resolved
azurerm/internal/services/mssql/mssql_server_data_source.go Outdated Show resolved Hide resolved
@yupwei68
Copy link
Contributor Author

@katbyte @jackofallops Sorry for my previous misunderstandings. I have pushed the changes. Please continue reviewing.

@ghost ghost removed the waiting-response label Sep 21, 2020
@yupwei68 yupwei68 requested a review from katbyte September 21, 2020 03:39
katbyte
katbyte approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yupwei68 - LGTM 👍

@katbyte katbyte merged commit 690ab63 into hashicorp:master Sep 21, 2020
katbyte added a commit that referenced this pull request Sep 21, 2020
@katbyte
update CHANGELOG.md for #7917
7e21ff4
@ghost
Copy link

ghost commented Sep 24, 2020

This has been released in version 2.29.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.29.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@jackofallops jackofallops Awaiting requested review from jackofallops

Assignees
No one assigned
Labels
documentation service/mssql Microsoft SQL Server size/XL
Projects
None yet
Milestone
v2.29.0
Development

Successfully merging this pull request may close these issues.

Merge azurerm_sql_database and azurerm_mssql_database
3 participants
@yupwei68 @katbyte @jackofallops