Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: please add the ability to specify site_config in azurerm_function_app #745

Closed
dcherniv opened this issue Jan 23, 2018 · 5 comments

Comments

@dcherniv
Copy link

azurerm_app_service supports site_config options. Since functions is essentially an app_service, please add the ability to specify site_config for it.
Without this, there's no way to control things like 32/64 bit workers and others.
image

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Jan 23, 2018

hey @dcherniv

Thanks for opening this issue :)

So that we can look into this (as there's differences between the App Service site config and a Function App site config) - would it be possible to know which fields are you looking to use within the site_config block?

Thanks!

@dcherniv
Copy link
Author

@tombuildsstuff
From: https://www.terraform.io/docs/providers/azurerm/r/app_service.html
always_on - (Optional) Should the app be loaded at all times? Defaults to false.
use_32_bit_worker_process - (Optional) Should the App Service run in 32 bit mode, rather than 64 bit mode?

use_32_bit_worker_process is probably more important because for me when function_app was provisioned with the following, it defaulted to 32 bit workers for some odd reason.

resource "azurerm_function_app" "default" {
  name                      = "${var.name}"
  location                  = "${var.region}"
  resource_group_name       = "${var.rg_name}"
  app_service_plan_id       = "${var.as_plan_id}"
  storage_connection_string = "${var.storage_connection}"
  app_settings              = "${var.app_settings}"
  tags {
     Environment    = "${var.tag_env}"
     Name           = "${var.tag_name}"
     Owner          = "${var.tag_owner}"
     Contact        = "${var.tag_contact}"
     CostProject    = "${var.tag_cost}"
     "Resource Group" = "${var.rg_name}"
  }
}

@gunzip
Copy link

gunzip commented Feb 23, 2018

I'd add client_affinity_enabled as well:

https://www.terraform.io/docs/providers/azurerm/r/app_service.html#client_affinity_enabled

This is very important in the context of Functions which are served behind an API management resource:
when you have client_affinity_enabled the Function backend sends a cookie with a domain which is not the same as the one of the API gateway.

@gunzip
Copy link

gunzip commented Feb 23, 2018

always_on is now supported thanks to
#695

cloudify added a commit to cloudify/terraform-provider-azurerm that referenced this issue Feb 23, 2018
tombuildsstuff added a commit that referenced this issue Mar 6, 2018
Issue #745, adds more options to azurerm_function_app
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants