-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add primary & secondary connection string to 'azurerm_iothub_dps_shared_access_policy' #5231
Add primary & secondary connection string to 'azurerm_iothub_dps_shared_access_policy' #5231
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @Brunhil, aside from needing some nil checks this is looking great.
Would it be easier if I created a new PR with the provider reorganization changes or pulled the changes in after the PR is approved @katbyte ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Brunhil, Either or would work. Just one comment i've left inline that once addressed this'll be good to merge
Fixes some parts of hashicorp#3692 and hashicorp#4970
* r/eventgrid_event_subscription: fixing TestAccAzureRMEventGridEventSubscription_basic * r/backup_policy_vm: fixing broken assertions * refactor: removing Location(), LocationAlt() and LocationAlt2()
…rp#5268) Partially addresses: hashicorp#5044 Adds the azurerm_api_management_identity_provider_aad resource.
Fix panic in 'azurerm_api_management_operation' Recreatd hashicorp#5243 after the changes to the provider organization.
End result for PR is ugly, but rebase is done :). Let me know your thoughts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the revisions @Brunhil! LGTM now 👍
This has been released in version 1.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.40.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Add primary_connection_string and secondary_connection_string to azurerm_iothub_dps_shared_access_policy
--- PASS: TestAccAzureRMIotHubDpsSharedAccessPolicy_writeWithoutRead (151.97s)
--- PASS: TestAccAzureRMIotHubDpsSharedAccessPolicy_enrollmentReadWithoutRegistration (166.87s)
--- PASS: TestAccAzureRMIotHubDpsSharedAccessPolicy_enrollmentWriteWithoutOthers (205.74s)
--- PASS: TestAccAzureRMIotHubDpsSharedAccessPolicy_basic (273.52s)