Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kubernetes_cluster does not support labels in an agent_pool_profile #4968

Closed
spanktar opened this issue Nov 23, 2019 · 4 comments · Fixed by #5531
Closed

azurerm_kubernetes_cluster does not support labels in an agent_pool_profile #4968

spanktar opened this issue Nov 23, 2019 · 4 comments · Fixed by #5531

Comments

@spanktar
Copy link

spanktar commented Nov 23, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It is possible to apply k8s labels to a node pool with the Azure CLI, but not with Terraform. node_taints are available, which is great, but we use a combination of taints and label matching to place pods. It would be great to add node_labels in the same style as node_taints.

@patrickbsf
Copy link

patrickbsf commented Nov 26, 2019

Thanks for reporting this and I agree this is a large omission.
Pods with nodeSelectors on them to only run on certain labeled nodes is a critical requirement for node pool configuration.
This is needed for the new azurerm_kubernetes_cluster_node_pool resource type as well as the default/agent pool profiles in the cluster resource.

@albertocsm
Copy link

albertocsm commented Jan 14, 2020

+1
i was really not expecting this... seems such a basic use case!

dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
@dintel
Copy link
Contributor

dintel commented Jan 27, 2020

Submitted PR that adds support of node_labels in relevant resources. Whom should I add as a reviewer?

dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Jan 27, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Feb 7, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Feb 13, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Feb 13, 2020
dintel added a commit to dintel/terraform-provider-azurerm that referenced this issue Feb 26, 2020
@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants