Create MongoDB v3.6 with azurerm_cosmosdb_account

[CapoD]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We need to create a CosmosDB with a MongoDB 3.6 API Version.

New or Affected Resource(s)

• azurerm_cosmosdb_account

Potential Terraform Configuration

capabilities {
    name = "MongoDBv3.6"
}

References

void

[peterbev]

I'm not a go developer but I'm assuming that the "good first issue" label is because at it's most basic, enabling MongoDB 3.6 simply needs EnableMongo adding to the capabilities:

"capabilities": {
	Type:     schema.TypeSet,
	Optional: true,
	Elem: &schema.Resource{
		Schema: map[string]*schema.Schema{
			"name": {
				Type:             schema.TypeString,
				Required:         true,
				DiffSuppressFunc: suppress.CaseDifference,
				ValidateFunc: validation.StringInSlice([]string{
					"EnableTable",
					"EnableGremlin",
					"EnableCassandra",
					"EnableMongo", // Enable MongoDB 3.6 wire protocol support
					"EnableAggregationPipeline",
					"MongoDBv3.4",
					"mongoEnableDocLevelTTL",
				}, true),
			},
		},
	},
	Set: resourceAzureRMCosmosDBAccountCapabilitiesHash,
},

However, as there is no validation of the capabilities I think it would only compound a situation that is already confusing:

• EnableTable, EnableGremlin and EnableCassandra are only valid with kind GlobalDocumentDB and are all mutually exclusive.
• EnableAggregationPipeline, MongoDBv3.4 and mongoEnableDocLevelTTL are only valid with kind MongoDB but are additive.

Adding EnableMongo which is not compatible with EnableAggregationPipeline, MongoDBv3.4 and mongoEnableDocLevelTTL as the latter are preview capabilities associated with the original MongoDB 3.2 to me just seems more confusing.

It's possible I'm over complicating things and it just needs calling out in the docs...

[peterbev]

Now I think about it, there's also the question of whether the resource needs to be recreated, EnableAggregationPipeline, MongoDBv3.4 and mongoEnableDocLevelTTL can be added to an existing CosmosDB account assuming it's of kind MongoDB and EnableMongo hasn't been specified. In all other cases the CosmosDB account will need recreating if capabilities are updated.

[peterbev]

Compiled a version for our own use that includes EnableMongo in capabilities and found it trips over this:

//for some reason capabilities doesn't always work on create, so lets patch it
//tracked: https://github.com/Azure/azure-sdk-for-go/issues/2864
future, err := client.Patch(ctx, resourceGroup, name, documentdb.DatabaseAccountPatchParameters{
	DatabaseAccountPatchProperties: &documentdb.DatabaseAccountPatchProperties{
		Capabilities: account.Capabilities,
	},
})

Crudely commented out to meet our requirements, something else to be aware of...

[aristosvo]

I'm trying to pick this up, but I'm not used to Go. I'll do my best:)

[ghost]

This has been released in version 1.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.42.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!