Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error was not propagated in log in #4724

Closed
boillodmanuel opened this issue Oct 25, 2019 · 2 comments · Fixed by #4725
Closed

Error was not propagated in log in #4724

boillodmanuel opened this issue Oct 25, 2019 · 2 comments · Fixed by #4725

Comments

@boillodmanuel
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

master

Details

Errors are not propagated in logs in:
https://github.com/terraform-providers/terraform-provider-azurerm/blob/30302a32b27c217fae049ec562fcd7a16d0c0cd6/azurerm/resource_arm_management_group.go#L161-L163

I do not check elsewhere, but it can worse to do it.

boillodmanuel added a commit to boillodmanuel/terraform-provider-azurerm that referenced this issue Oct 25, 2019
PR for hashicorp#4724 - Error was not propagated in log in
@tombuildsstuff tombuildsstuff added this to the v1.36.0 milestone Oct 25, 2019
tombuildsstuff added a commit that referenced this issue Oct 25, 2019
fix for #4724 - Error was not propagated in logs in
@ghost
Copy link

ghost commented Oct 29, 2019

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 24, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants