Add signalr args: 'service_mode' and 'allowed_origins'

[jackbatzner]

Fixes #4422 by adding service_mode and allowed_origins to the azurerm_signalr_service.

Needed to update the signalr api version as the preview version did not have these fields present. Added acceptance tests verifying as well.

[tombuildsstuff]

hey @Brunhil

Thanks for this PR :)

Taking a look through this is looking good - I've left a few comments inline but if we can fix those up then this otherwise LGTM 👍

Thanks!

[jackbatzner]

@tombuildsstuff - Addressed your comments, thanks for the feedback! I resolved your comments as well, let me know if this is okay to do.

[tombuildsstuff]

hey @Brunhil

Thanks for pushing those changes - taking a look through this now LGTM 👍

Thanks!

[tombuildsstuff]

hey @Brunhil

Thanks for pushing those changes - I've run the tests and it looks like there's a few minor issues to sort - but this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

hey @Brunhil

Thanks for pushing those changes - I've run the tests which noticed one issue:

which is failing because the domain "http://www.contoso.com" isn't a valid CORS Origin (which needs to be a domain name, without the schema). Taking a look through I've left a few other minor comments but if we can fix those up then this otherwise LGTM 👍

Thanks!

[tombuildsstuff]

hey @Brunhil

Thanks for pushing those changes - I've spent a little while debugging this and it appears there's an error in the tests which needed to be fixed to get this to run - as such I hope you don't mind but so that we can get this merged I've pushed a commit which fixes this.

Thanks!

[tombuildsstuff]

Tests pass:

[ghost]

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!