Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SignalR Serverless Mode #4945

Closed
SimonKienzler opened this issue Nov 21, 2019 · 4 comments
Closed

Support for SignalR Serverless Mode #4945

SimonKienzler opened this issue Nov 21, 2019 · 4 comments

Comments

@SimonKienzler
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The SignalR resource allows for a setting called "service mode" in both the portal and the template manager. It allows to choose between the settings "Default", "Serverless" and "Classic" (see references for more information on those options).

The feature is currently flagged as a preview, but has been around since march 2019. I'd like to be able to set this flag with Terraform as well.

New or Affected Resource(s)

azurerm_signalr_service

Potential Terraform Configuration

resource "azurerm_signalr_service" "example" {
  name                = "tfex-signalr"
  location            = "${azurerm_resource_group.example.location}"
  resource_group_name = "${azurerm_resource_group.example.name}"

  sku {
    name     = "Free_F1"
    capacity = 1
  }

  service_mode = "Serverless" # Other options: Default, Classic
}

References

I've never worked on a terraform provider before, but if this feature is welcome, I'd give it a shot!

@jackbatzner
Copy link
Contributor

Hi @SimonKienzler , this should be coming in 1.37!

This was fixed with #4716

@SimonKienzler
Copy link
Author

Great, thanks @Brunhil ! I didn't find anything when searching for "serverless" in the issues and PRs instead of "service_mode", my mistake. Looking forward to using the feature, thank you for implementing it. I'll close this :)

@tombuildsstuff tombuildsstuff added this to the v1.37.0 milestone Nov 22, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

This has been released in version 1.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.37.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants