Crash: terraform-provider-azurerm_v1.34.0_x4 not parsing empty strings

[sblack4]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.12.8
+ provider.azurerm v1.34.0
+ provider.errorcheck v2.0.3
+ provider.local v1.4.0
+ provider.tls v2.1.1

Affected Resource(s)

azurerm_virtual_machine

Terraform Configuration Files

resource "azurerm_virtual_machine" "this" {
  name                  = "${var.name}-vm"
  location              = var.location
  resource_group_name   = var.bastion_rg
  network_interface_ids = [azurerm_network_interface.this.id]
  vm_size               = var.vm_size

  delete_os_disk_on_termination    = true
  delete_data_disks_on_termination = true

  storage_os_disk {
    name          = "${var.name}-disc"
    create_option = "FromImage"
  }

  storage_image_reference {
    id = data.azurerm_image.bastion.id
    version = "0.0.3"
  }
  plan {
    name = ""
    publisher = ""
    product = ""
  }

  os_profile {
    computer_name  = "${var.name}host"
    admin_username = local.admin_username
  }
  os_profile_linux_config {
    disable_password_authentication = true
  }
}

Panic Output

crash.log: https://gist.github.com/sblack4/7e15d6fa8ae856631c3283710e50b906

Expected Behavior

1. Terraform would let me know it doesn't like empty strings

Actual Behavior

1. Terraform panicked

Steps to Reproduce

1. Put empty strings into the plan info
2. terraform apply

[tombuildsstuff]

relevant line: https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.34.0/azurerm/resource_arm_virtual_machine.go#L1397

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!