azurerm_network_security_rule & azurerm_network_security_rule - add support for Icmp to the protocol property

[ignatz42]

Attempt to fix #3937

[katbyte]

Thanks for the pr @ignatz42

We just need to update the docs with the new value and then this should be good to go 👍

[katbyte]

Hmm, oddly the TestAccAzureRMNetworkSecurityRule_addingRules test is failing with:

config is invalid: expected protocol to be one of [* Tcp Udp], got Icmp

[katbyte]

@ignatz42

You'll need to add the new value to the security rule resource as well and then the test will pass. I tried to push the required changes to you branch but i don't have permission.

[ignatz42]

@katbyte Thank you for the review and finding the test failure. I've updated the commit with a small docs change and the fix for the failure.

[katbyte]

Thanks @ignatz42! LGTM 👍

[katbyte]

Thanks @ignatz42! LGTM 👍

[ghost]

This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.36.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!