azurerm_network_security_rule & azurerm_network_security_rule -… (#4615)

Attempt to fix #3937
hashicorp · Oct 17, 2019 · a3ac5c6 · a3ac5c6
1 parent 7adc7ee
commit a3ac5c6
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 3 deletions.
diff --git a/azurerm/resource_arm_network_security_group.go b/azurerm/resource_arm_network_security_group.go
@@ -74,6 +74,7 @@ func resourceArmNetworkSecurityGroup() *schema.Resource {
 								string(network.SecurityRuleProtocolAsterisk),
 								string(network.SecurityRuleProtocolTCP),
 								string(network.SecurityRuleProtocolUDP),
+								string(network.SecurityRuleProtocolIcmp),
 							}, true),
 							DiffSuppressFunc: suppress.CaseDifference,
 						},

diff --git a/azurerm/resource_arm_network_security_rule.go b/azurerm/resource_arm_network_security_rule.go
@@ -61,6 +61,7 @@ func resourceArmNetworkSecurityRule() *schema.Resource {
 					string(network.SecurityRuleProtocolAsterisk),
 					string(network.SecurityRuleProtocolTCP),
 					string(network.SecurityRuleProtocolUDP),
+					string(network.SecurityRuleProtocolIcmp),
 				}, true),
 				DiffSuppressFunc: suppress.CaseDifference,
 			},

diff --git a/azurerm/resource_arm_network_security_rule_test.go b/azurerm/resource_arm_network_security_rule_test.go
@@ -351,7 +351,7 @@ resource "azurerm_network_security_rule" "test2" {
   priority                    = 101
   direction                   = "Inbound"
   access                      = "Deny"
-  protocol                    = "Tcp"
+  protocol                    = "Icmp"
   source_port_range           = "*"
   destination_port_range      = "*"
   source_address_prefix       = "*"

diff --git a/website/docs/r/network_security_group.html.markdown b/website/docs/r/network_security_group.html.markdown
@@ -67,7 +67,7 @@ Elements of `security_rule` support:
 
 * `description` - (Optional) A description for this rule. Restricted to 140 characters.
 
-* `protocol` - (Required) Network protocol this rule applies to. Can be `Tcp`, `Udp` or `*` to match both.
+* `protocol` - (Required) Network protocol this rule applies to. Can be `Tcp`, `Udp`, `Icmp`, or `*` to match all.
 
 * `source_port_range` - (Optional) Source Port or Range. Integer or range between `0` and `65535` or `*` to match any. This is required if `source_port_ranges` is not specified.
 

diff --git a/website/docs/r/network_security_rule.html.markdown b/website/docs/r/network_security_rule.html.markdown
@@ -56,7 +56,7 @@ The following arguments are supported:
 
 * `description` - (Optional) A description for this rule. Restricted to 140 characters.
 
-* `protocol` - (Required) Network protocol this rule applies to. Possible values include `Tcp`, `Udp` or `*` (which matches both).
+* `protocol` - (Required) Network protocol this rule applies to. Possible values include `Tcp`, `Udp`, `Icmp`, or `*` (which matches all).
 
 * `source_port_range` - (Optional) Source Port or Range. Integer or range between `0` and `65535` or `*` to match any. This is required if `source_port_ranges` is not specified.