storage_account: Ignore Advanced Threat Protection read errors in Azure Germany #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Azure Germany Cloud returns `HTTP/2.0 404 Not Found` when requesting the ATP details. In particular, ``` Code="InvalidResourceNamespace" Message="The resource namespace 'Microsoft.Security' is invalid." ``` As we are simply ignoring the error on Azure Government based on hashicorp#3920, we can apply the same logic for Azure Germany. Closes hashicorp#4563.
katbyte
changed the title
katbyte
added a commit
that referenced
this pull request
Oct 9, 2019
|
This has been released in version 1.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 1.36.0"
}
# ... other configuration ... |
sigv
added a commit
to sigv/terraform-provider-azurerm
that referenced
this pull request
Oct 29, 2019
Although the error message returned from Azure Germany Cloud is precisely "The resource namespace 'Microsoft.Security' is invalid." the error message we are seeing in `r/storage_account` has other contents added on it, so we cannot do an equals check directly. The ATP fix was being pushed as v1.36.0, but this change provides the actual resolution. Ref hashicorp#4563, hashicorp#4564.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Azure Germany Cloud returns
HTTP/2.0 404 Not Foundwhen requesting the ATP details. In particular,As we are simply ignoring the error on Azure Government based on #3920, we can apply the same logic for Azure Germany.
Closes #4563.