azurerm_service_fabric_cluster support for client certificates common name

[arestarh]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

You should be able to add both an admin and reader client certificates for Service Fabric clusters using either certificate thumbprint or common name.
Currently there is a support only for adding client certificates using certificate thumbprint via client_certificate_thumbprint block.

Adding client certificates using either certificate thumbprint or common name should be mutually exclusive, so this 2 options will not conflict.

I've raised this as a feature, but it could be argued that this is a bug.

New or Affected Resource(s)

• azurerm_service_fabric_cluster

Potential Terraform Configuration

client_certificate_common_names {
   certificate_common_name = "fabricam.com"
   certificate_issuer_thumbprint = "8c2462bd8af801206f3284780e8f63271774902b"
   is_admin = false
}

[arestarh]

@katbyte As long as PR #6097 addressed my request should I close this issue or you'll do this?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!