Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Load balancer to support PublicIPPrefix as frontendipconfiguration #3675

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

NillsF
Copy link
Contributor

@NillsF NillsF commented Jun 14, 2019

Reason for the pull request: It was not possible to create a outboundrule using a PublicIpPrefix, as the frontendipconfiguration in terraform didn't support PublicIpPrefix. This PR contains that fix, plus also a minor update to a regular load balancer rule to allow the disableoutboundsnat to be set on a load balancer rule.

Major contribution: PublicIPPrefix as frontendIPConfiguration

I made changes to azurerm\resource_arm_loadbalancer.go to allow a PublicIPPrefix to be used for a frontendipconfiguration. I edited two test files to have the required tests to cover this: azurerm\resource_arm_loadbalancer_test.go and azurerm\resource_arm_loadbalancer_outbound_rule_test.go

Minor contribution: enable disableoutboundsnat on a load balancer rule to be set from Terraform.

I made changes to azurerm\resource_arm_loadbalancer_rule.go to allow the disableoutboundsnat parameter to be set. I also edited the test file for load balancer rule to have a new test scenario for these rules azurerm\resource_arm_loadbalancer_test.go.

@ghost ghost added the size/L label Jun 14, 2019
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @NillsF

Thanks for this PR :)

Taking a look through this mostly LGTM - if we can add the documentation for the two new fields this otherwise LGTM 👍

Thanks!

azurerm/resource_arm_loadbalancer.go Show resolved Hide resolved
azurerm/resource_arm_loadbalancer_rule.go Show resolved Hide resolved
azurerm/resource_arm_loadbalancer_rule.go Outdated Show resolved Hide resolved
@ghost ghost added the documentation label Jun 17, 2019
@NillsF
Copy link
Contributor Author

NillsF commented Jun 17, 2019

@tombuildsstuff :
Docs added, removed the if check on disable_outbound_snat.

@ghost ghost removed the waiting-response label Jun 17, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @NillsF! LGTM & tests pass 👍

katbyte added a commit that referenced this pull request Jun 18, 2019
@katbyte katbyte merged commit 264f711 into hashicorp:master Jun 18, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 19, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants