Attribute "address_space" differ between "resource_arm_virtual_network" and "data_source_virtual_network"

[bgauduch]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Hi there !

The schema address_space is different in data_source_virtual_network.go and resource_arm_virtual_network.go.

This is misleading when using data source and virtual network, it should be consistent across resources.

Anyway, awesome product, keep up the good work 👍

New or Affected Resource(s)

• data.azurerm_virtual_network (data_source_virtual_network.go)
• resource.azurerm_virtual_network (resource_arm_virtual_network.go)

Potential Terraform Configuration

Not directly related to a specific configuration.

Here is the related error one can stumble upon:

* azurerm_subnet.demo_subnet: Resource 'data.azurerm_virtual_network.demo_vnet' does not have attribute 'address_space' for variable 'data.azurerm_virtual_network.demo_vnet.address_space'

=> the s is mising

References

[bgauduch]

Created PR #3384 just now 😉
CC @tombuildsstuff

[bgauduch]

Well, this attribute naming issue is in fact related to inconsistencies in the Azure documentation on the web interface, az CLI, API, etc.

As discussed in the PR #3384, numerous changes should be done :
Rename the property address_space to address_spaces (if this is the good attribute name) in all code and documentation related to virtual networks. As this is a core Azure feature and a breaking change in the provider, it should be done on a 3 steps basis (as advised by @katbyte):

• add the new property, tag it as conflicting with the existing one, release
• tag the old one as deprecated, release
• remove the old one, realase

Those modifications are quite heavier than I initially expected, and should indeed be synchronized with the release cycle.

Any advise / feedback / correction on this ?
CC @tombuildsstuff @katbyte

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!