Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_api_management.security.disable_triple_des_chipers has incorrect spelling #3021

Closed
seanchambersgray opened this issue Mar 7, 2019 · 3 comments · Fixed by #3539
Closed

Comments

@seanchambersgray
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform (and AzureRM Provider) Version

Terraform v0.11.11

  • provider.azurerm v1.22.1

Affected Resource(s)

  • azurerm_api_management

Terraform Configuration Files

resource "azurerm_api_management" "example" {
  name                = "example"
  location            = "${azurerm_resource_group.example.location}"
  resource_group_name = "${azurerm_resource_group.example.name}"
  publisher_name      = "My Company"
  publisher_email     = "[email protected]"
  sku {
    name     = "Standard"
    capacity = 1
  }
  security {
    disable_triple_des_chipers = true
  }
}

Expected Behavior

The property azurerm_api_management.security.disable_triple_des_chipers should be spelt azurerm_api_management.security.disable_triple_des_ciphers.

Actual Behavior

The property is spelt azurerm_api_management.security.disable_triple_des_chipers.

Suggested resolution

I'm happy to submit a pull request updating the name of this property, but this would be a breaking change so would appreciate guidance on how you'd like to handle that.

@mbfrahry
Copy link
Member

mbfrahry commented May 17, 2019

Hey @SeanEGray, thanks for opening this issue. Apologies for the delay. Luckily this is a fairly straightforward fix. You'll want to add the new attribute and add a ConflictsWith: []string{"security.0.disable_triple_des_chipers"}. Then in the wrongly named attribute, you'll add a deprecated messaged like `

Deprecated:    "This property has been deprecated in favour of security.0.disable_triple_des_ciphers property. This  will be removed in version 2.0 of the provider",

.

You'll want to keep the old attribute the same apart from that deprecated message but make sure that you read/set the new attribute name properly in the create/update/read methods. We'll go in and remove the misspelled attribute when we release 2.0. Feel free to ask any further questions and I'll be happy to help get this issue closed if you don't have the time anymore.

@ReenuSaluja
Copy link
Contributor

I will work on this.

ReenuSaluja added a commit to ReenuSaluja/terraform-provider-azurerm that referenced this issue May 29, 2019
@ghost
Copy link

ghost commented Jul 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants