New Resource: azurerm_data_protection_backup_instance_mysql_flexible_server

[neil-yechenwei]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support Data Protection Backup Instance for MySQL FS.

API Reference: https://github.com/Azure/azure-rest-api-specs/tree/main/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2024-04-01

Overview: https://learn.microsoft.com/en-us/azure/postgresql/flexible-server/concepts-backup-restore#long-term-retention-preview

Note: This PR is referring the existing Backup Instances in RP https://github.com/hashicorp/terraform-provider-azurerm/tree/main/internal/services/dataprotection.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• New Resource: azurerm_data_protection_backup_instance_mysql_flexible_server

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[ms-zhenhua]

Hi @neil-yechenwei,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

[neil-yechenwei]

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look.

Below is the latest test result I just now triggered.

[ms-zhenhua]

Hi @neil-yechenwei , thank you for your update. LGTM~

[katbyte]

test failure

------- Stdout: -------
=== RUN   TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic
=== PAUSE TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic
=== CONT  TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic
    testcase.go:173: Step 1/3 error: Error running apply: exit status 1
        
        Error: creating Flexible Server (Subscription: "*******"
        Resource Group Name: "acctest-dataprotection-241016175940838067"
        Flexible Server Name: "acctest-mysqlfs-241016175940838067"): polling after Create: polling failed: the Azure API returned the following error:
        
        Status: "ZoneNotAvailableForRegion"
        Code: ""
        Message: "The requested size for resource is currently not available in this zone. Please try another zone or deploy to a different location"
        Activity Id: ""
        
        ---
        
        API Response:
        
        ----[start]----
        {"name":"d4b8a22a-f57b-4863-965a-cf540392eb18","status":"Failed","startTime":"2024-10-16T18:00:08.933Z","error":{"code":"ZoneNotAvailableForRegion","message":"The requested size for resource is currently not available in this zone. Please try another zone or deploy to a different location"}}
        -----[end]-----
        
        
          with azurerm_mysql_flexible_server.test,
          on terraform_plugin_test.tf line 37, in resource "azurerm_mysql_flexible_server" "test":
          37: resource "azurerm_mysql_flexible_server" "test" {
        
--- FAIL: TestAccDataProtectionBackupInstanceMySQLFlexibleServer_basic (223.58s)
FAIL

[neil-yechenwei]

@katbyte , I updated PR. Please take another look. Below is the test result that I just now triggered.

[katbyte]

@neil-yechenwei - went to test this and the build failed for tc due to an API upgrade on main

 data_protection_backup_instance_mysql_flexible_server_resource.go:17:2: cannot find module providing package github.com/hashicorp/go-azure-sdk/resource-manager/mysql/2022-01-01/servers: import lookup disabled by -mod=vendor
[08:57:37][Step 4/5] 	(Go version in go.mod is at least 1.14 and vendor directory exists.)

you'll need to merge main and resolve conflicts

[neil-yechenwei]

@katbyte , I merged latest change. Below is the latest test result I just now triggered.

Note: the failure of CI check is not related with this PR.

[katbyte]

Thanks LGTM 🚂

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.