Skip to content

Commit

Permalink
update pr per comments
Browse files Browse the repository at this point in the history
  • Loading branch information
neil-yechenwei committed Sep 24, 2024
1 parent 200262d commit 66f37c5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,13 @@ func (r DataProtectionBackupInstanceMySQLFlexibleServerResource) Read() sdk.Reso
if props := model.Properties; props != nil {
state.Location = location.NormalizeNilable(props.DataSourceInfo.ResourceLocation)

serverId, err := servers.ParseFlexibleServerID(props.DataSourceInfo.ResourceID)
serverId, err := servers.ParseFlexibleServerIDInsensitively(props.DataSourceInfo.ResourceID)
if err != nil {
return err
}
state.ServerId = serverId.ID()

backupPolicyId, err := backuppolicies.ParseBackupPolicyID(props.PolicyInfo.PolicyId)
backupPolicyId, err := backuppolicies.ParseBackupPolicyIDInsensitively(props.PolicyInfo.PolicyId)
if err != nil {
return err
}
Expand Down Expand Up @@ -236,6 +236,9 @@ func (r DataProtectionBackupInstanceMySQLFlexibleServerResource) Update() sdk.Re

return fmt.Errorf("reading %s: %+v", *id, err)
}
if existing.Model == nil {
return fmt.Errorf("retrieving %s: `model` was nil", id)
}

parameters := *existing.Model

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ The following arguments are supported:

* `location` - (Required) The location of the source database. Changing this forces a new resource to be created.

* `vault_id` - (Required) The ID of the Backup Vault within which the MySQL Flexible Server Backup Instance should exist. Changing this forces a new resource to be created.
* `backup_policy_id` - (Required) The ID of the Backup Policy.

* `server_id` - (Required) The ID of the source server. Changing this forces a new resource to be created.

* `backup_policy_id` - (Required) The ID of the Backup Policy.
* `vault_id` - (Required) The ID of the Backup Vault within which the MySQL Flexible Server Backup Instance should exist. Changing this forces a new resource to be created.

## Attributes Reference

Expand Down

0 comments on commit 66f37c5

Please sign in to comment.