Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_bastion_host - support new SKU Premium and session_recording_enabled property #27278

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

T0biii
Copy link
Contributor

@T0biii T0biii commented Sep 4, 2024

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

We want to use Bastion Premium and the feature session recording

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have written new tests for my resource or datasource changes & updated any relevent documentation.
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)
    image

currently have no test subscription and also i think #27277 needs to be merged first

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

  • azurerm_bastion_host - support new SKU Premium and feature Session recording

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Related Issue(s)

Fixes #27013
#27277 needs to be merged first

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

@T0biii T0biii changed the title azurerm_bastion_host - support new SKU Premium and feature Session recording azurerm_bastion_host - support new SKU Premium and feature Session recording Sep 4, 2024
@T0biii

This comment was marked as resolved.

@T0biii
Copy link
Contributor Author

T0biii commented Sep 20, 2024

Test seems to pass now :)
image

The CI failing because of Vendor Dependencies Check / depscheck should be fixed by: #27445

@T0biii
Copy link
Contributor Author

T0biii commented Sep 20, 2024

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have a test failure here:

------- Stdout: -------
=== RUN   TestAccBastionHost_premiumSku
=== PAUSE TestAccBastionHost_premiumSku
=== CONT  TestAccBastionHost_premiumSku
    testcase.go:130: Step 1/3 error: Error running apply: exit status 1
        
        Error: `session_recording_enabled` is only supported when `sku` is `Premium`
        
          with azurerm_bastion_host.test,
          on terraform_plugin_test.tf line 58, in resource "azurerm_bastion_host" "test":
          58: resource "azurerm_bastion_host" "test" {
        
--- FAIL: TestAccBastionHost_premiumSku (158.69s)
FAIL

@T0biii

This comment was marked as outdated.

Copy link
Contributor Author

@T0biii T0biii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@T0biii T0biii requested a review from katbyte September 21, 2024 11:21
@T0biii T0biii force-pushed the add-bastion-premium branch from e7b102c to 4e25386 Compare September 21, 2024 11:49
@T0biii T0biii force-pushed the add-bastion-premium branch from 4e25386 to 653b18a Compare September 21, 2024 11:51
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than ks LGTM 🌻

@katbyte katbyte merged commit d513c58 into hashicorp:main Oct 11, 2024
33 checks passed
@katbyte katbyte changed the title azurerm_bastion_host - support new SKU Premium and feature Session recording azurerm_bastion_host - support new SKU Premium and session_recording_enabled property Oct 11, 2024
@github-actions github-actions bot added this to the v4.5.0 milestone Oct 11, 2024
katbyte added a commit that referenced this pull request Oct 11, 2024
@T0biii T0biii deleted the add-bastion-premium branch October 11, 2024 06:45
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Bastion Premium SKU
2 participants