azurerm_monitor_scheduled_query_rules_alert_v2 - correctly handling identity block if not specified

[teowa]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

context: #25365

Confirmed with service team that identity None type means no access, so alert won't be trigger. So we cannot send identity[type: None] but need to omit the identity block if not specified.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

TF_ACC=1 go test -v ./internal/services/monitor -parallel 5 -run TestAccMonitorScheduledQueryRulesAlertV2_identity -timeout 2h -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMonitorScheduledQueryRulesAlertV2_identitySystemAssigned
=== PAUSE TestAccMonitorScheduledQueryRulesAlertV2_identitySystemAssigned
=== RUN   TestAccMonitorScheduledQueryRulesAlertV2_identityUpdate
=== PAUSE TestAccMonitorScheduledQueryRulesAlertV2_identityUpdate
=== CONT  TestAccMonitorScheduledQueryRulesAlertV2_identitySystemAssigned
=== CONT  TestAccMonitorScheduledQueryRulesAlertV2_identityUpdate
--- PASS: TestAccMonitorScheduledQueryRulesAlertV2_identitySystemAssigned (210.99s)
--- PASS: TestAccMonitorScheduledQueryRulesAlertV2_identityUpdate (327.96s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       327.992s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_monitor_scheduled_query_rules_alert_v2 - correctly handling identity block if not specified

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #26347
Fixes #25921
Fixes #25995

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[katbyte]

LGTM 🌪️

[babula000]

@teowa Please review this fix, as it seems to to be applicable for new resources only. For existing alerts identity remains None which is causing the alert to fail. For fixing the issue we have to delete and recreate alert with 3.110.0 version, can this be fixed so existing alerts can also be managed automatically.

[teowa]

Hi @babula000 , we can only fix the issue for newly create/update alert rule. So a update need to be triggered to fix the issue for existing rules, e.g. modifing the tags.

[babula000]

Hi @teowa I have tried updating the tag for the alerts but identity property remain unchanged as None. Please check the scenario from your end

[teowa]

Apologize @babula000 , updating other properties doesn't work, you may need to update the identity property, or recreate the resource with terraform apply -replace='azurerm_monitor_scheduled_query_rules_alert_v2.example'

[babula000]

@teowa any plan to provide fix for this in future release ?

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.