Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Availability Sets to Managed Disks #2614

Closed
errygg opened this issue Jan 7, 2019 · 5 comments · Fixed by #5724
Closed

Default Availability Sets to Managed Disks #2614

errygg opened this issue Jan 7, 2019 · 5 comments · Fixed by #5724

Comments

@errygg
Copy link

errygg commented Jan 7, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently Managed Disks default to false for the azurerm_availability_set resource; however, Managed Disks default to true in the Azure Portal per https://docs.microsoft.com/en-us/azure/virtual-machines/windows/faq-for-disks. Suggest that the default for Managed Disks be set to true in the azurerm_availability_set resource.

New or Affected Resource(s)

  • azurerm_availability_set

Potential Terraform Configuration

N/A

References

https://docs.microsoft.com/en-us/azure/virtual-machines/windows/faq-for-disks

@metacpp

This comment has been minimized.

@tombuildsstuff
Copy link
Contributor

@metacpp we can update this value in 2.0, since it'll be a breaking change

@metacpp

This comment has been minimized.

@ghost
Copy link

ghost commented Feb 24, 2020

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants