azurerm_monitor_smart_detector_alert_rule - Normalize action_group.ids

[magodo]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

In most cases, the action_group is a reference from an azurerm_monitor_action_group, which is fine. Whilst for other cases, where the action group of this alert rule is referenced from other means, the resource id might be not of the expected form (especially the actionGroup section can be actiongroup), which violates the validation defined in

terraform-provider-azurerm/internal/services/monitor/monitor_smart_detector_alert_rule_resource.go

Line 118 in 4b72a21

ValidateFunc: validate.ActionGroupID,

.

One live example can be found at Azure/aztfexport#259

This PR normalizes the action_group.ids during Read.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

terraform-provider-azurerm on  monitor_smart_detector_alert_rule_actionGroup_id_norm via 🐹 v1.22.1
💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/monitor -run='TestAccMonitorSmartDetectorAlertRule_basic'
=== RUN   TestAccMonitorSmartDetectorAlertRule_basic
=== PAUSE TestAccMonitorSmartDetectorAlertRule_basic
=== CONT  TestAccMonitorSmartDetectorAlertRule_basic
--- PASS: TestAccMonitorSmartDetectorAlertRule_basic (155.75s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       155.769s

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_monitor_smart_detector_alert_rule - Normalize action_group.ids [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes Azure/aztfexport#259

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[tombuildsstuff]

One minor thing but otherwise LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.