New Resource: `azurerm_system_center_virtual_machine_manager_virtual_network` #25451

neil-yechenwei · 2024-03-28T06:11:43Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave "+1" or "me too" comments, they generate extra noise for PR followers and do not help prioritize for review

Description

This PR is to support new resource System Center Virtual Machine Manager Virtual Network in SCVMM RP. Maybe these three PRs (#25449, #25451, #25429) need to be merged one by one.

Change Log

azurerm_system_center_virtual_machine_manager_virtual_network - support this new resource

This is a (please select all that apply):

Bug Fix
New Feature (ie adding a service, resource, or data source)
Enhancement
Breaking Change

Test Result

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/basic (337.94s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/requiresImport (316.53s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/complete (324.14s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/update (462.05s)

References

Azure doc
REST API specs

…etwork

ms-zhenhua

Hi @neil-yechenwei ,
Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

...entervirtualmachinemanager/system_center_virtual_machine_manager_virtual_network_resource.go

...virtualmachinemanager/system_center_virtual_machine_manager_virtual_network_resource_test.go

neil-yechenwei · 2024-04-03T08:29:35Z

@ms-zhenhua , thanks for the comments. I updated PR. Please take another look. Thanks.

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/requiresImport (347.64s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/complete (252.80s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/update (538.39s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/basic (323.89s)

ms-zhenhua

@neil-yechenwei , thank you for your updates. LGTM~

…machinemanagervirtualnetwork

neil-yechenwei · 2024-06-19T03:03:21Z

@katbyte , I noticed that the PR to add stateRefreshFunc has been merged. So I updated this PR to remove the time sleep accordingly. Below is the test result I just now triggered.

--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/basic (436.33s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/requiresImport (323.29s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/complete (310.89s)
--- PASS: TestAccSystemCenterVirtualMachineManagerVirtualNetworkSequential/scvmmVirtualNetwork/update (581.43s)

katbyte

LGTM 🧁

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.108.0" to "3.109.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.109.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.109.0
FEATURES:

* **New Data Source:** `azurerm_automation_runbook` ([#26359](hashicorp/terraform-provider-azurerm#26359 **New Resource:** `azurerm_data_protection_backup_instance_postgresql_flexible_server` ([#26249](hashicorp/terraform-provider-azurerm#26249 **New Resource:** `azurerm_email_communication_service_domain` ([#26179](hashicorp/terraform-provider-azurerm#26179 **New Resource:** `azurerm_system_center_virtual_machine_manager_cloud` ([#25429](hashicorp/terraform-provider-azurerm#25429 **New Resource:** `azurerm_system_center_virtual_machine_manager_virtual_machine_template` ([#25449](hashicorp/terraform-provider-azurerm#25449 **New Resource:** `azurerm_system_center_virtual_machine_manager_virtual_network` ([#25451](https://github.com/hashicorp/terraform-provider-azurerm/issues/25451))

ENHANCEMENTS:

* Data Source: `azurerm_hdinsight_cluster` - export the `cluster_id` attribute ([#26228](hashicorp/terraform-provider-azurerm#26228 `azurerm_cosmosdb_sql_container` - support for the `partition_key_kind` and `partition_key_paths` properties ([#26372](hashicorp/terraform-provider-azurerm#26372 `azurerm_data_protection_backup_instance_blob_storage` - support for the `storage_account_container_names` property ([#26232](hashicorp/terraform-provider-azurerm#26232 `azurerm_virtual_network_peering` - support for the `peer_complete_virtual_networks_enabled`, `only_ipv6_peering_enabled`, `local_subnet_names`, and `remote_subnet_names` properties ([#26229](hashicorp/terraform-provider-azurerm#26229 `azurerm_virtual_desktop_host_pool` - changing the `preferred_app_group_type` property no longer creates a new resource ([#26333](hashicorp/terraform-provider-azurerm#26333 `azurerm_maps_account` - support for the `location`, `identity`, `cors` and `data_store` properties ([#26397](https://github.com/hashicorp/terraform-provider-azurerm/issues/26397))

BUG FIXES:

* `azurerm_automation_job_schedule` - updates `azurerm_automation_job_schedule` to use a composite resource id and allows `azurerm_automation_runbook` to be updated without causing `azurerm_automation_job_schedule` to recreate ([#22164](hashicorp/terraform-provider-azurerm#22164 `azurerm_databricks_workspace`- correctly allow disabling the default firewall ([#26339](hashicorp/terraform-provider-azurerm#26339 `azurerm_virtual_hub_*` - spliting create and update so lifecycle ignore changes works correctly ([#26310](https://github.com/hashicorp/terraform-provider-azurerm/issues/26310))

DEPRECATIONS:

* Data Source: `azurerm_mariadb_server` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_configuration` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server_configuration` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_database` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_database` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_firewall_rule` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server_firewall_rule` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_server` - deprecated since the service is retiring. Please use `azurerm_mysql_flexible_server` instead ([#26354](hashicorp/terraform-provider-azurerm#26354 `azurerm_mariadb_virtual_network_rule` - deprecated since the service is retiring ([#26354](https://github.com/hashicorp/terraform-provider-azurerm/issues/26354))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/256/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-07-22T02:13:08Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

neil-yechenwei added 3 commits November 30, 2023 13:31

New Resource: azurerm_system_center_virtual_machine_manager_virtual_n…

6ec617a

…etwork

update code

e860970

update code

dc1930a

neil-yechenwei marked this pull request as draft March 28, 2024 06:11

github-actions bot added documentation service/systemcentervirtualmachinemanager size/XL labels Mar 28, 2024

ms-zhenhua suggested changes Apr 2, 2024

View reviewed changes

github-actions bot added the waiting-response label Apr 2, 2024

update code

9070859

github-actions bot removed the waiting-response label Apr 3, 2024

neil-yechenwei requested a review from ms-zhenhua April 3, 2024 08:29

ms-zhenhua approved these changes Apr 9, 2024

View reviewed changes

neil-yechenwei marked this pull request as ready for review April 9, 2024 02:23

This was referenced Apr 9, 2024

New Resource: azurerm_system_center_virtual_machine_manager_cloud #25429

Merged

New Resource: azurerm_system_center_virtual_machine_manager_virtual_machine_template #25449

Merged

katbyte assigned catriona-m Apr 23, 2024

catriona-m added the blocked label May 13, 2024

neil-yechenwei added 2 commits May 28, 2024 18:13

merge latest change

df78239

remove time_sleep

911c2a0

github-actions bot added the waiting-response label Jun 14, 2024

neil-yechenwei added 2 commits June 14, 2024 14:04

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

12898f8

…machinemanagervirtualnetwork

merge latest change

359232f

github-actions bot removed the waiting-response label Jun 14, 2024

Merge remote-tracking branch 'upstream/main' into systemcentervirtual…

f1b8071

…machinemanagervirtualnetwork

katbyte approved these changes Jun 19, 2024

View reviewed changes

neil-yechenwei and others added 2 commits June 20, 2024 09:13

merge latest change

73d61da

Merge branch 'main' into systemcentervirtualmachinemanagervirtualnetwork

578a2c4

katbyte merged commit e7b101a into hashicorp:main Jun 21, 2024
33 checks passed

github-actions bot added this to the v3.109.0 milestone Jun 21, 2024

katbyte added a commit that referenced this pull request Jun 21, 2024

Update CHANGELOG.md #25451

822d2af

github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_system_center_virtual_machine_manager_virtual_network` #25451

New Resource: `azurerm_system_center_virtual_machine_manager_virtual_network` #25451

neil-yechenwei commented Mar 28, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Apr 3, 2024 •

edited

Loading

ms-zhenhua left a comment

neil-yechenwei commented Jun 19, 2024

katbyte left a comment

github-actions bot commented Jul 22, 2024

New Resource: azurerm_system_center_virtual_machine_manager_virtual_network #25451

New Resource: azurerm_system_center_virtual_machine_manager_virtual_network #25451

Conversation

neil-yechenwei commented Mar 28, 2024 • edited Loading

Community Note

Description

Change Log

Test Result

References

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Apr 3, 2024 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

neil-yechenwei commented Jun 19, 2024

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 22, 2024

New Resource: `azurerm_system_center_virtual_machine_manager_virtual_network` #25451

New Resource: `azurerm_system_center_virtual_machine_manager_virtual_network` #25451

neil-yechenwei commented Mar 28, 2024 •

edited

Loading

neil-yechenwei commented Apr 3, 2024 •

edited

Loading