Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_synapse_spark_pool - added spark pool 3.4 support for Synapse #25319

Merged
merged 3 commits into from
Mar 19, 2024
Merged

azurerm_synapse_spark_pool - added spark pool 3.4 support for Synapse #25319

merged 3 commits into from
Mar 19, 2024

Conversation

daniel-brown-improving
Copy link
Contributor

@daniel-brown-improving daniel-brown-improving commented Mar 19, 2024 •
edited
Loading

Created Issue for this: #25318

Updated azurerm_synapse_spark_pool resource to add support for spark_pool_version 3.4. Also, updated the default version to be 3.4, which is the latest version.

@daniel-brown-improving daniel-brown-improving mentioned this pull request Mar 19, 2024
Closed
1 task
@daniel-brown-improving daniel-brown-improving changed the title Added Spark Pool 3.4 Support for Synapse azurerm_synapse_spark_pool - added spark pool 3.4 support for Synapse Mar 19, 2024
@daniel-brown-improving daniel-brown-improving changed the title azurerm_synapse_spark_pool - added spark pool 3.4 support for Synapse azurerm_synapse_spark_pool - added spark pool 3.4 support for Synapse Mar 19, 2024
@rcskosir rcskosir linked an issue Mar 19, 2024 that may be closed by this pull request
Add support for spark_pool_version 3.4 to azurerm_synapse_spark_pool #25318
Closed
1 task
@daniel-brown-improving @tombuildsstuff
Update internal/services/synapse/synapse_spark_pool_resource.go
b091d72 
I think this is the way.

Co-authored-by: Tom Harvey <[email protected]>
mbfrahry
mbfrahry requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @daniel-brown-improving, this PR looks good but we shouldn't change the default behavior between minor versions as that could break people.

internal/services/synapse/synapse_spark_pool_resource.go Outdated Show resolved Hide resolved
website/docs/r/synapse_spark_pool.html.markdown Outdated Show resolved Hide resolved
@mbfrahry
Copy link
Member

Oh my. I didn't realize this PR would be such a hot topic! Apologies for the double review @daniel-brown-improving!

@daniel-brown-improving @mbfrahry
Update website/docs/r/synapse_spark_pool.html.markdown
f7fa4f0 
Removing deprecation language from docs

Co-authored-by: Matthew Frahry <[email protected]>
tombuildsstuff
tombuildsstuff approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pushing those changes @daniel-brown-improving

@daniel-brown-improving
Copy link
Contributor Author

Oh my. I didn't realize this PR would be such a hot topic! Apologies for the double review @daniel-brown-improving!

No worries. I'm glad you guys care that much.

@katbyte katbyte merged commit 03f71b6 into hashicorp:main Mar 19, 2024
33 checks passed
@github-actions github-actions bot added this to the v3.97.0 milestone Mar 19, 2024
katbyte added a commit that referenced this pull request Mar 19, 2024
@katbyte
Update CHANGELOG.md #25319
5d1b1bb
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry requested changes

@katbyte katbyte katbyte requested changes

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation service/synapse size/XS
Projects
None yet
Milestone
v3.97.0
Development

Successfully merging this pull request may close these issues.

Add support for spark_pool_version 3.4 to azurerm_synapse_spark_pool
4 participants
@daniel-brown-improving @mbfrahry @tombuildsstuff @katbyte