Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account - Support local_user_enabled #24800

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Feb 7, 2024

This PR adds a new property local_user_enabled to azurerm_storage_account.

This feature is actually used when SFTP is enabled (which in turns requires the HNS is enabled), see this for details. However, the API actually accepts the isLocalUserEnabled properties regardless the SFTP state. Azure Portal also allows manage isLocalUserEnabled regardless of sftpEnabled, as long as the HNS is enabled so that you have access to the "SFTP" blade.

When creating the storage account without specifying the isLocalUserEnabled in the request, the API defaults to true, hence the default value set in the schema (and the init value set in Read()). This is to avoid breaking changes.

Fix #24797

Test

💢  TF_ACC=1 go test -v -timeout=20h -run='TestAccStorageAccount_isLocalUserEnabled|TestAccStorageAccount_basic' ./internal/services/storage
=== RUN   TestAccStorageAccount_basic
=== PAUSE TestAccStorageAccount_basic
=== RUN   TestAccStorageAccount_isLocalUserEnabled
=== PAUSE TestAccStorageAccount_isLocalUserEnabled
=== CONT  TestAccStorageAccount_basic
=== CONT  TestAccStorageAccount_isLocalUserEnabled
--- PASS: TestAccStorageAccount_basic (175.51s)
--- PASS: TestAccStorageAccount_isLocalUserEnabled (188.51s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       188.535s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this @magodo

@mbfrahry mbfrahry added this to the v3.91.0 milestone Feb 7, 2024
@mbfrahry mbfrahry merged commit 68f080f into hashicorp:main Feb 7, 2024
32 checks passed
mbfrahry added a commit that referenced this pull request Feb 7, 2024
lemeurherve pushed a commit to jenkins-infra/azure that referenced this pull request Feb 9, 2024
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azurerm&#34; updated from
&#34;3.90.0&#34; to &#34;3.91.0&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.91.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.91.0&#xA;FEATURES:&#xA;&#xA;*
**New Data Source**: `azurerm_databricks_access_connector`
([#24769](hashicorp/terraform-provider-azurerm#24769
**New Resource**:
`azurerm_data_protection_backup_policy_kubernetes_cluster`
([#24718](hashicorp/terraform-provider-azurerm#24718
**New Resource**: `azurerm_chaos_studio_experiment`
([#24779](hashicorp/terraform-provider-azurerm#24779
**New Resource**: `azurerm_chaos_studio_capability`
([#24779](hashicorp/terraform-provider-azurerm#24779
**New Resource**: `azurerm_dev_center_gallery`
([#23760](hashicorp/terraform-provider-azurerm#23760
**New Resource:** `azurerm_kubernetes_fleet_member`
([#24792](hashicorp/terraform-provider-azurerm#24792
**New Resource:** `azurerm_iotcentral_organization`
([#23132](hashicorp/terraform-provider-azurerm#23132
**New Resource:**
`azurerm_spring_cloud_app_dynamics_application_performance_monitoring`
([#24750](https://github.com/hashicorp/terraform-provider-azurerm/issues/24750))&#xA;&#xA;ENHANCEMENTS:&#xA;&#xA;*
dependencies: updating to `v0.20240208.1095436` of
`github.com/hashicorp/go-azure-sdk/resource-manager`
([#24819](hashicorp/terraform-provider-azurerm#24819
dependencies: updating to `v0.20240208.1095436` of
`github.com/hashicorp/go-azure-sdk/sdk`
([#24819](hashicorp/terraform-provider-azurerm#24819
dependencies: refactor `azurerm_app_service_environment_v3` to use
`go-azure-sdk`
([#24760](hashicorp/terraform-provider-azurerm#24760
dependencies: refactor `azurerm_role_definition` to use `go-azure-sdk`
([#24266](hashicorp/terraform-provider-azurerm#24266
`managedhsm`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24761](hashicorp/terraform-provider-azurerm#24761
`hdinsight`: updating to API Version `2023-07-01`
([#24761](hashicorp/terraform-provider-azurerm#24761
`streamanalytics`: updating to use the transport layer from
`hashicorp/go-azure-sdk` rather than `Azure/go-autorest`
([#24819](hashicorp/terraform-provider-azurerm#24819
`azurerm_app_service_environment_v3` - support for the
`remote_debugging_enabled` property
([#24760](hashicorp/terraform-provider-azurerm#24760
`azurerm_storage_account` - support for the `local_user_enabled`
property
([#24800](hashicorp/terraform-provider-azurerm#24800
`azurerm_log_analytics_workspace_table` - support for the
`total_retention_in_days` property
([#24513](hashicorp/terraform-provider-azurerm#24513
`azurerm_maching_learning_workspace` - support for the `feature_store`
and `kind` properties
([#24716](hashicorp/terraform-provider-azurerm#24716
`azurerm_traffic_manager_azure_endpoint` - support for the
`always_serve_enabled` property
([#24573](hashicorp/terraform-provider-azurerm#24573
`azurerm_traffic_manager_external_endpoint` - support for the
`always_serve_enabled` property
([#24573](https://github.com/hashicorp/terraform-provider-azurerm/issues/24573))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_api_management` - the
`virtual_network_configuration` property now updates correctly outside
of `virtual_network_type`
([#24569](https://github.com/hashicorp/terraform-provider-azurerm/issues/24569))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1083/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for isLocalUserEnabled parameter in azurerm_storage_account
2 participants