New resource: `azurerm_data_protection_backup_policy_kubernetes_cluster` #24718

sinbai · 2024-01-31T06:01:28Z

Swagger : https://github.com/Azure/azure-rest-api-specs/blob/f3cd6922dbe117d78b4f719bbf8b03db46b30808/specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L864

Test results:

ms-zhenhua

Hi @sinbai, Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

ms-zhenhua · 2024-02-01T01:39:06Z

...services/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource.go

+									ValidateFunc: validation.StringInSlice([]string{
+										string(backuppolicies.AbsoluteMarkerAllBackup),
+										string(backuppolicies.AbsoluteMarkerFirstOfDay),
+										string(backuppolicies.AbsoluteMarkerFirstOfMonth),
+										string(backuppolicies.AbsoluteMarkerFirstOfWeek),
+										string(backuppolicies.AbsoluteMarkerFirstOfYear),
+									}, false),


shall we use validation.StringInSlice(backuppolicies.PossibleValuesFor...(), false), instead?

ms-zhenhua · 2024-02-01T01:40:11Z

...services/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource.go

+										ValidateFunc: validation.StringInSlice([]string{
+											string(backuppolicies.WeekNumberFirst),
+											string(backuppolicies.WeekNumberSecond),
+											string(backuppolicies.WeekNumberThird),
+											string(backuppolicies.WeekNumberFourth),
+											string(backuppolicies.WeekNumberLast),
+										}, false),


shall we use validation.StringInSlice(backuppolicies.PossibleValuesFor...(), false), instead?

ms-zhenhua · 2024-02-01T02:06:27Z

...services/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource.go

+									ValidateFunc: validate.ISO8601Duration,
+								},
+
+								"target_copy_setting": {


default_retention_rule.target_copy_setting is not found in testcase?

The target_copy_setting property has been removed.

ms-zhenhua · 2024-02-01T02:14:42Z

...services/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource.go

+			model := resp.Model
+			if model == nil {
+				return fmt.Errorf("retrieving %s: model was nil", id)
+			}


please use if model := resp.Model; model != nil {....

ms-zhenhua · 2024-02-01T02:17:43Z

...services/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource.go

+			resp, err := client.Get(ctx, *id)
+			if err != nil {
+				if response.WasNotFound(resp.HttpResponse) {
+					return metadata.MarkAsGone(id)


Suggested change

return metadata.MarkAsGone(id)

return metadata.MarkAsGone(*id)

ms-zhenhua · 2024-02-01T02:58:41Z

...ces/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource_test.go

+	})
+}
+
+func TestAccDataProtectionBackupPolicyKubernatesCluster_update(t *testing.T) {


since all properties are forceNew, this update can be removed?

Yes, fixed.

ms-zhenhua · 2024-02-01T03:05:35Z

website/docs/r/data_protection_backup_policy_kubernetes_cluster.html.markdown

+
+A `life_cycle` block supports the following:
+
+* `data_store_type` - (Required) The type of data store. Possible values is `OperationalStore`. 


Suggested change

* `data_store_type` - (Required) The type of data store. Possible values is `OperationalStore`.

* `data_store_type` - (Required) The type of data store. The only possible value is `OperationalStore`.

ms-zhenhua · 2024-02-01T03:06:27Z

website/docs/r/data_protection_backup_policy_kubernetes_cluster.html.markdown

+
+* `copy_after` - (Required) Specifies when the backups are tiered across two or more selected data stores as a json encoded string. Changing this forces a new resource to be created.
+
+* `data_store_type` - (Required) The target copy data store type. Possible values is `OperationalStore`. 


Suggested change

* `data_store_type` - (Required) The target copy data store type. Possible values is `OperationalStore`.

* `data_store_type` - (Required) The target copy data store type. The only possible value is `OperationalStore`.

ms-zhenhua · 2024-02-01T03:13:27Z

...ces/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource_test.go

+    life_cycle {
+      duration        = "P7D"
+      data_store_type = "OperationalStore"
+      target_copy_setting {
+        copy_after = jsonencode({
+          objectType = "ImmediateCopyOption"
+        })
+        data_store_type = "OperationalStore"
+      }
+    }
+
+    life_cycle {
+      duration        = "P84D"
+      data_store_type = "OperationalStore"
+    }


does it make sense to have 2 life_cycle blocks with the same data_store_type?

Yes, the duration may vary. Below is the real data created in Azure Portal.

ms-zhenhua · 2024-02-01T03:15:44Z

website/docs/r/data_protection_backup_policy_kubernetes_cluster.html.markdown

+
+A `target_copy_setting` block supports the following:
+
+* `copy_after` - (Required) Specifies when the backups are tiered across two or more selected data stores as a json encoded string. Changing this forces a new resource to be created.


since there is only one type of data_store_type. Do there exist a real scenario that the backups are tiered across two or more selected data stores?

Thank you for your question. Yes, this has been confirmed with the services team, but is currently in preview (feature is already supported in Azure Portal). Considering that the service team did not request onboard this preview feature this time, I deleted target_copy_setting in the code, set to empty array.

sinbai · 2024-02-01T07:14:26Z

Hi @sinbai, Thanks for this PR - I've taken a look through and left some comments inline. If we can fix those up, this should be good to go 👍

Hi @ms-zhenhua thanks for your time and valuable feedback. I have fixed/commented feedback. Could you please take another look?

Retested results are as follows:
PASS: TestAccDataProtectionBackupPolicyKubernatesCluster_basic (280.25s)
PASS: TestAccDataProtectionBackupPolicyKubernatesCluster_requiresImport (313.35s)
PASS: TestAccDataProtectionBackupPolicyKubernatesCluster_complete (293.88s)

ms-zhenhua · 2024-02-01T09:02:28Z

...services/dataprotection/azurerm_data_protection_backup_policy_kubernetes_cluster_resource.go

+	results := backuppolicies.AzureRetentionRule{}
+	if len(input) == 0 {
+		return results
+	}


if len(input)==0, we should not return an empty rule. In this case, no rule should be added to the policyRules list outside this method?

Thanks for your feedback, fixed.

katbyte

LGTM 📏

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.90.0" to "3.91.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.91.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.91.0
FEATURES:

* **New Data Source**: `azurerm_databricks_access_connector` ([#24769](hashicorp/terraform-provider-azurerm#24769 **New Resource**: `azurerm_data_protection_backup_policy_kubernetes_cluster` ([#24718](hashicorp/terraform-provider-azurerm#24718 **New Resource**: `azurerm_chaos_studio_experiment` ([#24779](hashicorp/terraform-provider-azurerm#24779 **New Resource**: `azurerm_chaos_studio_capability` ([#24779](hashicorp/terraform-provider-azurerm#24779 **New Resource**: `azurerm_dev_center_gallery` ([#23760](hashicorp/terraform-provider-azurerm#23760 **New Resource:** `azurerm_kubernetes_fleet_member` ([#24792](hashicorp/terraform-provider-azurerm#24792 **New Resource:** `azurerm_iotcentral_organization` ([#23132](hashicorp/terraform-provider-azurerm#23132 **New Resource:** `azurerm_spring_cloud_app_dynamics_application_performance_monitoring` ([#24750](https://github.com/hashicorp/terraform-provider-azurerm/issues/24750))

ENHANCEMENTS:

* dependencies: updating to `v0.20240208.1095436` of `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24819](hashicorp/terraform-provider-azurerm#24819 dependencies: updating to `v0.20240208.1095436` of `github.com/hashicorp/go-azure-sdk/sdk` ([#24819](hashicorp/terraform-provider-azurerm#24819 dependencies: refactor `azurerm_app_service_environment_v3` to use `go-azure-sdk` ([#24760](hashicorp/terraform-provider-azurerm#24760 dependencies: refactor `azurerm_role_definition` to use `go-azure-sdk` ([#24266](hashicorp/terraform-provider-azurerm#24266 `managedhsm`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24761](hashicorp/terraform-provider-azurerm#24761 `hdinsight`: updating to API Version `2023-07-01` ([#24761](hashicorp/terraform-provider-azurerm#24761 `streamanalytics`: updating to use the transport layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24819](hashicorp/terraform-provider-azurerm#24819 `azurerm_app_service_environment_v3` - support for the `remote_debugging_enabled` property ([#24760](hashicorp/terraform-provider-azurerm#24760 `azurerm_storage_account` - support for the `local_user_enabled` property ([#24800](hashicorp/terraform-provider-azurerm#24800 `azurerm_log_analytics_workspace_table` - support for the `total_retention_in_days` property ([#24513](hashicorp/terraform-provider-azurerm#24513 `azurerm_maching_learning_workspace` - support for the `feature_store` and `kind` properties ([#24716](hashicorp/terraform-provider-azurerm#24716 `azurerm_traffic_manager_azure_endpoint` - support for the `always_serve_enabled` property ([#24573](hashicorp/terraform-provider-azurerm#24573 `azurerm_traffic_manager_external_endpoint` - support for the `always_serve_enabled` property ([#24573](https://github.com/hashicorp/terraform-provider-azurerm/issues/24573))

BUG FIXES:

* `azurerm_api_management` - the `virtual_network_configuration` property now updates correctly outside of `virtual_network_type` ([#24569](https://github.com/hashicorp/terraform-provider-azurerm/issues/24569))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1083/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

…er` (hashicorp#24718) * resolve conflict * update code * update code to fix internal review feedback * update code * update code

github-actions · 2024-04-29T02:08:50Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/data-protection size/XL waiting-response and removed waiting-response labels Jan 31, 2024

ms-zhenhua suggested changes Feb 1, 2024

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Feb 1, 2024

ms-zhenhua suggested changes Feb 1, 2024

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Feb 1, 2024

sinbai added 5 commits February 2, 2024 09:44

resolve conflict

885f81a

update code

7a77603

update code to fix internal review feedback

6cfcae3

update code

17b42db

update code

3c757cd

sinbai force-pushed the dataprotection/support_aks_backup_policy branch from c9b8495 to 3c757cd Compare February 2, 2024 01:45

sinbai marked this pull request as ready for review February 2, 2024 02:22

katbyte approved these changes Feb 9, 2024

View reviewed changes

katbyte merged commit de2dc41 into hashicorp:main Feb 9, 2024
33 checks passed

katbyte added a commit that referenced this pull request Feb 9, 2024

Update CHANGELOG.md #24718

4c19b5f

github-actions bot added this to the v3.91.0 milestone Feb 9, 2024

rizkybiz pushed a commit to rizkybiz/terraform-provider-azurerm that referenced this pull request Feb 29, 2024

Update CHANGELOG.md hashicorp#24718

a4948b3

sinbai deleted the dataprotection/support_aks_backup_policy branch March 28, 2024 02:41

github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: `azurerm_data_protection_backup_policy_kubernetes_cluster` #24718

New resource: `azurerm_data_protection_backup_policy_kubernetes_cluster` #24718

sinbai commented Jan 31, 2024 •

edited

Loading

ms-zhenhua left a comment

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

sinbai commented Feb 1, 2024 •

edited

Loading

ms-zhenhua Feb 1, 2024

sinbai Feb 1, 2024

katbyte left a comment

github-actions bot commented Apr 29, 2024

	return metadata.MarkAsGone(id)
	return metadata.MarkAsGone(*id)


		A `life_cycle` block supports the following:

		* `data_store_type` - (Required) The type of data store. Possible values is `OperationalStore`.


		* `copy_after` - (Required) Specifies when the backups are tiered across two or more selected data stores as a json encoded string. Changing this forces a new resource to be created.

		* `data_store_type` - (Required) The target copy data store type. Possible values is `OperationalStore`.


		A `target_copy_setting` block supports the following:

		* `copy_after` - (Required) Specifies when the backups are tiered across two or more selected data stores as a json encoded string. Changing this forces a new resource to be created.

New resource: azurerm_data_protection_backup_policy_kubernetes_cluster #24718

New resource: azurerm_data_protection_backup_policy_kubernetes_cluster #24718

Conversation

sinbai commented Jan 31, 2024 • edited Loading

ms-zhenhua left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sinbai commented Feb 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 29, 2024

New resource: `azurerm_data_protection_backup_policy_kubernetes_cluster` #24718

New resource: `azurerm_data_protection_backup_policy_kubernetes_cluster` #24718

sinbai commented Jan 31, 2024 •

edited

Loading

sinbai commented Feb 1, 2024 •

edited

Loading