azurerm_linux_function_app azurerm_function_app_slot azurerm_windows_function_app azurerm_windows_function_app - taint resource when resource was partially created.

[lonegunmanb]

This pr should resolve #24517.

#24517 was caused by the following code:

                        if functionApp.ZipDeployFile != "" {
				if err = helpers.GetCredentialsAndPublish(ctx, client, id.ResourceGroup, id.SiteName, functionApp.ZipDeployFile); err != nil {
					return err
				}
			}

			metadata.SetID(id)

Once an error occurred during GetCredentialsAndPublish, the Create function would return error without recording resource's state, but on the service side the resource was partially created, when the user run apply again, the Create function would read a resource with the very same id, then threw an error that required user to import the resource.

This pr pushed metadata.SetID(id) right after we've created the resource.

Actually, this behavior is as same as we're doing for azurerm_linux_web_app_resource and azurerm_linux_web_app_slot.

Once the id was set and Create function returned an error, the resource was recorded in the state file with tainted status, when the user run apply again, Terraform would try to delete the partially created resource first, then try to create it again.

@tombuildsstuff @jackofallops WDYT?

[stephybun]

Thanks @lonegunmanb LGTM 👍

[stephybun]

@lonegunmanb would you mind resolving the merge conflicts?

[katbyte]

@lonegunmanb - could you fix up these merge conflicts

[lonegunmanb]

@stephybun @katbyte sorry for the late reply, would you please give this pr another review? Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.