new resource: `azurerm_kubernetes_fleet_update_strategy` #24328

ms-henglu · 2023-12-25T07:52:32Z

=== RUN   TestAccKubernetesFleetUpdateStrategy_basic
=== PAUSE TestAccKubernetesFleetUpdateStrategy_basic
=== CONT  TestAccKubernetesFleetUpdateStrategy_basic
=== RUN   TestAccKubernetesFleetUpdateStrategy_requiresImport
=== PAUSE TestAccKubernetesFleetUpdateStrategy_requiresImport
=== CONT  TestAccKubernetesFleetUpdateStrategy_requiresImport
=== RUN   TestAccKubernetesFleetUpdateStrategy_complete
=== PAUSE TestAccKubernetesFleetUpdateStrategy_complete
=== CONT  TestAccKubernetesFleetUpdateStrategy_complete
=== RUN   TestAccKubernetesFleetUpdateStrategy_update
=== PAUSE TestAccKubernetesFleetUpdateStrategy_update
=== CONT  TestAccKubernetesFleetUpdateStrategy_update
--- PASS: TestAccKubernetesFleetUpdateStrategy_complete (528.40s)
--- PASS: TestAccKubernetesFleetUpdateStrategy_basic (584.65s)
--- PASS: TestAccKubernetesFleetUpdateStrategy_update (601.25s)
--- PASS: TestAccKubernetesFleetUpdateStrategy_requiresImport (611.02s)
PASS

magodo

Thanks for this PR!
I have left some additional mostly minor comments that once addressed this should be good to merge 👍

internal/services/containers/kubernetes_fleet_update_strategy_resource_test.go

stephybun

Thanks @ms-henglu. I left a few comments in-line, can you please take a look?

stephybun · 2024-01-22T15:09:17Z

internal/services/containers/kubernetes_fleet_update_strategy_resource.go

+}
+
+type KubernetesFleetUpdateStrategyResourceSchema struct {
+	FleetId  string                                                         `tfschema:"fleet_manager_id"`


We should spell this out

Suggested change

FleetId string `tfschema:"fleet_manager_id"`

FleetId string `tfschema:"kubernetes_fleet_manager_id"`

stephybun · 2024-01-22T15:23:21Z

internal/services/containers/kubernetes_fleet_update_strategy_resource.go

+		"strategy": {
+			Required: true,
+			MaxItems: 1,
+			Type:     pluginsdk.TypeList,
+			Elem: &pluginsdk.Resource{


Since we already know this resource is managing a strategy and this can have at most one item we should remove this and just expose the stage

Suggested change

"strategy": {

Required: true,

MaxItems: 1,

Type: pluginsdk.TypeList,

Elem: &pluginsdk.Resource{

katbyte

LGTM 🚢

<Actions> <action id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8"> <h3>Bump Terraform `azurerm` provider version</h3> <details id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24"> <summary>Update Terraform lock file</summary> <p>changes detected:
	"hashicorp/azurerm" updated from "3.89.0" to "3.90.0" in file ".terraform.lock.hcl"</p> <details> <summary>3.90.0</summary> <pre>Changelog retrieved from:
	https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.90.0
UPGRADE NOTES:

* provider - The provider will now automatically register the `AppConfiguration`, `DataFactory`, and `SignalRService` Resource Providers. When running Terraform with limited permissions, note that you [must disable automatic Resource Provider Registration and ensure that any Resource Providers Terraform requires are registered]([XXX](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration)). ([#24645](hashicorp/terraform-provider-azurerm#24645; 
FEATURES:

* **New Data Source**: `azurerm_nginx_configuration` ([#24642](hashicorp/terraform-provider-azurerm#24642 **New Data Source**: `azurerm_virtual_desktop_workspace` ([#24732](hashicorp/terraform-provider-azurerm#24732 **New Resource**: `azurerm_kubernetes_fleet_update_strategy` ([#24328](hashicorp/terraform-provider-azurerm#24328 **New Resource**: `azurerm_site_recovery_vmware_replicated_vm` ([#22477](hashicorp/terraform-provider-azurerm#22477 **New Resource**: `azurerm_spring_cloud_new_relic_application_performance_monitoring` ([#24699](https://github.com/hashicorp/terraform-provider-azurerm/issues/24699))

ENHANCEMENTS:

* provider: registering the Resource Provider `Microsoft.AppConfiguration` ([#24645](hashicorp/terraform-provider-azurerm#24645 provider: registering the Resource Provider `Microsoft.DataFactory` ([#24645](hashicorp/terraform-provider-azurerm#24645 provider: registering the Resource Provider `Microsoft.SignalRService` ([#24645](hashicorp/terraform-provider-azurerm#24645 provider: the Provider is now built using Go 1.21.6 ([#24653](hashicorp/terraform-provider-azurerm#24653 dependencies: the dependency `github.com/hashicorp/go-azure-sdk` has been split into multiple Go Modules - and as such will be referred to by those paths going forwards ([#24636](hashicorp/terraform-provider-azurerm#24636 dependencies: updating to ``v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24738](hashicorp/terraform-provider-azurerm#24738 dependencies: updating to `v0.20240201.1064937` of `github.com/hashicorp/go-azure-sdk/sdk` ([#24738](hashicorp/terraform-provider-azurerm#24738 `appservice`: update to `go-azure-sdk` and API version `2023-01-01` ([#24688](hashicorp/terraform-provider-azurerm#24688 `datafactory`: updating to use `tombuildsstuff/kermit` ([#24675](hashicorp/terraform-provider-azurerm#24675 `hdinsight`: refactoring to use `github.com/hashicorp/go-azure-sdk/resource-manager` ([#24011](hashicorp/terraform-provider-azurerm#24011 `hdinsight`: updating to API Version `2021-06-01` ([#24011](hashicorp/terraform-provider-azurerm#24011 `loadbalancer`: updating to use `hashicorp/go-azure-sdk` ([#24291](hashicorp/terraform-provider-azurerm#24291 `nginx`: updating to API Version `2023-09-01` ([#24640](hashicorp/terraform-provider-azurerm#24640 `servicefabricmanagedcluster`: updating to use the base layer from `hashicorp/go-azure-sdk` rather than `Azure/go-autorest` ([#24654](hashicorp/terraform-provider-azurerm#24654 `springcloud`: updating to use API Version `2023-11-01-preview` ([#24690](hashicorp/terraform-provider-azurerm#24690 `subscriptions`: refactoring to use `hashicorp/go-azure-sdk` ([#24663](hashicorp/terraform-provider-azurerm#24663 Data Source: `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](hashicorp/terraform-provider-azurerm#24738 `azurerm_cosmosdb_account` - support for the `gremlin_database` and `tables_to_restore` properties ([#24627](hashicorp/terraform-provider-azurerm#24627 `azurerm_bot_channel_email` - support for the `magic_code` property ([#23129](hashicorp/terraform-provider-azurerm#23129 `azurerm_cosmosdb_account` - support for the `partition_merge_enabled` property ([#24615](hashicorp/terraform-provider-azurerm#24615 `azurerm_mssql_managed_database` - support for the `immutable_backups_enabled` property ([#24745](hashicorp/terraform-provider-azurerm#24745 `azurerm_mssql_database` - support for the `immutable_backups_enabled` property ([#24745](hashicorp/terraform-provider-azurerm#24745 `azurerm_palo_alto_next_generation_firewall_virtual_hub_panorama` - support for the `trusted_address_ranges` property ([#24459](hashicorp/terraform-provider-azurerm#24459 `azurerm_palo_alto_next_generation_firewall_virtual_network_local_rulestack` - support for the `trusted_address_ranges` property ([#24459](hashicorp/terraform-provider-azurerm#24459 `azurerm_palo_alto_next_generation_firewall_virtual_network_panorama` - support for the `trusted_address_ranges` property ([#24459](hashicorp/terraform-provider-azurerm#24459 `azurerm_servicebus_namespace` - updating to use API Version `2022-10-01-preview` ([#24650](hashicorp/terraform-provider-azurerm#24650 `azurerm_spring_cloud_api_portal` - support for the `api_try_out_enabled` property ([#24696](hashicorp/terraform-provider-azurerm#24696 `azurerm_spring_cloud_gateway` - support for the `local_response_cache_per_route` and `local_response_cache_per_instance` properties ([#24697](hashicorp/terraform-provider-azurerm#24697 `azurerm_stream_analytics_job` - support for User Assigned Identities ([#24738](hashicorp/terraform-provider-azurerm#24738 `azurerm_subscription` - refactoring to use `hashicorp/go-azure-sdk` to set tags on the subscription ([#24734](hashicorp/terraform-provider-azurerm#24734 `azurerm_virtual_desktop_workspace` - correctly validate the `name` property ([#24668](https://github.com/hashicorp/terraform-provider-azurerm/issues/24668))


BUG FIXES:

* provider: skip registration for resource providers that are unavailable ([#24571](hashicorp/terraform-provider-azurerm#24571 `azurerm_app_configuration` - no longer require `lifecycle_ignore_changes` for the `value` property when using a key vault reference ([#24702](hashicorp/terraform-provider-azurerm#24702 `azurerm_app_service_managed_certificate` - fix casing issue in `app_service_plan_id` by parsing insensitively ([#24664](hashicorp/terraform-provider-azurerm#24664 `azurerm_cognitive_deployment` - updates now include the `version` property ([#24700](hashicorp/terraform-provider-azurerm#24700 `azurerm_dns_cname_record` - prevent casing issue in `target_resource_id` by parsing the ID insensitively ([#24181](hashicorp/terraform-provider-azurerm#24181 `azurerm_mssql_managed_instance_failover_group` - prevent an issue when trying to create a failover group with a managed instance from a different subscription ([#24646](hashicorp/terraform-provider-azurerm#24646 `azurerm_storage_account` - conditionally update properties only when needed ([#24669](hashicorp/terraform-provider-azurerm#24669 `azurerm_storage_account` - change update order for `access_tier`to prevent errors when uploading blobs to the archive tier ([#22250](https://github.com/hashicorp/terraform-provider-azurerm/issues/22250))


</pre> </details> </details> <a href="https://infra.ci.jenkins.io/job/terraform-jobs/job/azure/job/main/1075/">Jenkins pipeline link</a> </action> </Actions> --- <table> <tr> <td width="77"> <img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli logo" width="50" height="50"> </td> <td> <p> Created automatically by <a href="https://www.updatecli.io/">Updatecli</a> </p> <details><summary>Options:</summary> <br /> <p>Most of Updatecli configuration is done via <a href="https://www.updatecli.io/docs/prologue/quick-start/">its manifest(s)</a>.</p> <ul> <li>If you close this pull request, Updatecli will automatically reopen it, the next time it runs.</li> <li>If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.</li> </ul> <p> Feel free to report any issues at <a href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br /> If you find this tool useful, do not hesitate to star <a href="https://github.com/updatecli/updatecli/stargazers">our GitHub repository</a> as a sign of appreciation, and/or to tell us directly on our <a href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>! </p> </details> </td> </tr> </table> Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>

github-actions · 2024-04-25T02:09:16Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

new resource: azurerm_kubernetes_fleet_update_strategy

d12271f

github-actions bot added documentation dependencies size/XL labels Dec 25, 2023

magodo requested changes Dec 25, 2023

View reviewed changes

internal/services/containers/kubernetes_fleet_update_strategy_resource_test.go Outdated Show resolved Hide resolved

github-actions bot added the waiting-response label Dec 25, 2023

update tests

6450c72

github-actions bot removed the waiting-response label Dec 28, 2023

ms-henglu marked this pull request as ready for review January 2, 2024 02:07

stephybun requested changes Jan 22, 2024

View reviewed changes

stephybun added new-resource service/kubernetes-cluster labels Jan 22, 2024

github-actions bot added the waiting-response label Jan 22, 2024

update

6728f27

github-actions bot removed the waiting-response label Jan 29, 2024

update

ca1caa7

github-actions bot added the waiting-response label Jan 29, 2024

ms-henglu added 2 commits January 29, 2024 16:18

Merge branch 'main' into ticket-25626618-fleet-update-strategry

536063a

go mod

b767642

github-actions bot added waiting-response and removed waiting-response labels Jan 29, 2024

fix

fb8778d

github-actions bot removed the waiting-response label Jan 29, 2024

Merge branch 'main' into ticket-25626618-fleet-update-strategry

0385f43

katbyte approved these changes Feb 2, 2024

View reviewed changes

katbyte merged commit 2915a57 into hashicorp:main Feb 2, 2024
33 checks passed

katbyte added a commit that referenced this pull request Feb 2, 2024

Update CHANGELOG.md #24328

65d040b

github-actions bot added this to the v3.90.0 milestone Feb 2, 2024

github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new resource: `azurerm_kubernetes_fleet_update_strategy` #24328

new resource: `azurerm_kubernetes_fleet_update_strategy` #24328

ms-henglu commented Dec 25, 2023

magodo left a comment

stephybun left a comment

stephybun Jan 22, 2024

stephybun Jan 22, 2024

katbyte left a comment

github-actions bot commented Apr 25, 2024

	FleetId string `tfschema:"fleet_manager_id"`
	FleetId string `tfschema:"kubernetes_fleet_manager_id"`

new resource: azurerm_kubernetes_fleet_update_strategy #24328

new resource: azurerm_kubernetes_fleet_update_strategy #24328

Conversation

ms-henglu commented Dec 25, 2023

magodo left a comment

Choose a reason for hiding this comment

stephybun left a comment

Choose a reason for hiding this comment

stephybun Jan 22, 2024

Choose a reason for hiding this comment

stephybun Jan 22, 2024

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 25, 2024

new resource: `azurerm_kubernetes_fleet_update_strategy` #24328

new resource: `azurerm_kubernetes_fleet_update_strategy` #24328