loadbalancer: refactoring to use hashicorp/go-azure-sdk

[sinbai]

• Upgrade loadbalancer to use hashicorp/go-azure-sdk and upgrade the API version to 2023-06-01.
  (Because this PR is upgraded from track1 SDK to pandora SDK, the upgraded SDK and API version are combined into one PR. )

• Remove the computed and add default value Tcp for property protocol of resource azurerm_lb_probe
  (Because the following error is caused by using Pandora SDK, the fix and the SDK upgrade are merged into one PR. )

  This is because some test cases of resource azurerm_lb_probe failed with the following error after upgrading SDK:

  { "error":{ "code":"InvalidRequestFormat", "message":"Cannot parse the request.", "details":[ { "code":"InvalidJson", "message":"Error converting value \"\" to type 'Microsoft.WindowsAzure.Networking.Nrp.Frontend.Contract.Csm.Public.Protocol'. Path 'properties.probes[0].properties.protocol', line 1, position 1257." } ] } }

The above error occurs when the property protocol is not specified in tf config. In this case, in the API request, the protocol is set to string empty, so the API returns the above error.

After verifying the API behavior, it was found that the default value of the protocol is Tcp. So, removing the computed and add default value for protocol to fix the tests failure. See test results below for more details.

1. sku = "Basic"
   PUT /subscriptions/xxx/resourceGroups/acctestRG-lb-test/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-1222

Request:
{
   ...
      "probes":[
         {
            "name":"probe-1222",
            "properties":{
               "intervalInSeconds":15,
               "numberOfProbes":2,
               "port":80,
               "probeThreshold":1
            }
         }
      ]
   },
   "sku":{
      "name":"Basic",
      "tier":"Regional"
   },
   "tags":{
      
   }
}

Response:
{
  "name": "arm-test-loadbalancer-1222",
    ...
    "probes": [
      {
        "name": "probe-1222",
        "id": "/subscriptions/xxx/resourceGroups/acctestRG-lb-test/providers/Microsoft.Network/loadBalancers/arm-test-loadbalancer-1222/probes/probe-1222",
        "etag": "W/\"600e0103-42ed-4bce-bce9-8f9964409bed\"",
        "properties": {
          "provisioningState": "Succeeded",
          "protocol": "Tcp",
          "port": 80,
          "intervalInSeconds": 15,
          "numberOfProbes": 2,
          "probeThreshold": 1
        },
        "type": "Microsoft.Network/loadBalancers/probes"
      }
    ],
    "inboundNatRules": [],
    "inboundNatPools": []
  },
  "sku": {
    "name": "Basic",
    "tier": "Regional"
  }
}

2. sku = "Standard"
   PUT /subscriptions/xxx/resourceGroups/acctestRG-lb-1222-5/providers/Microsoft.Network/loadBalancers/acctest-loadbalancer-1222-2

Request:	
{
	     ...
	      "probes":[
	         {
	            "name":"probe-1222",
	            "properties":{
	               "intervalInSeconds":15,
	               "numberOfProbes":2,
	               "port":20,
	               "probeThreshold":1
	            }
	         }
	      ]
	   },
	   "sku":{
	      "name":"Standard",
	      "tier":"Regional"
	   },
	   "tags":{
	      
	   }
	}

Response:
{
	  "name": "acctest-loadbalancer-1222-2",
	   ...
	    "probes": [
	      {
	        "name": "probe-1222",
	        "id": "/subscriptions/xxx/resourceGroups/acctestRG-lb-1222-5/providers/Microsoft.Network/loadBalancers/acctest-loadbalancer-1222-2/probes/probe-1222",
	        "etag": "W/\"ed047950-1768-4aa5-a265-ae4a4f9b2c41\"",
	        "properties": {
	          "provisioningState": "Succeeded",
	          "protocol": "Tcp",
	          "port": 20,
	          "intervalInSeconds": 15,
	          "numberOfProbes": 2,
	          "probeThreshold": 1
	        },
	        "type": "Microsoft.Network/loadBalancers/probes"
	      }
	    ],
	    "inboundNatRules": [],
	    "outboundRules": [],
	    "inboundNatPools": []
	  },
	  "sku": {
	    "name": "Standard",
	    "tier": "Regional"
	  }
	}

3. sku = "Standard"
   PUT /subscriptions/xxx/resourceGroups/acctestRG-lb-1222-5/providers/Microsoft.Network/loadBalancers/acctestlb-1222-3

Request:
{
	      ...
	      "probes":[
	         {
	            "name":"probe-1223",
	            "properties":{
	               "intervalInSeconds":15,
	               "numberOfProbes":2,
	               "port":20,
	               "probeThreshold":1
	            }
	         }
	      ]
	   },
	   "sku":{
	      "name":"Gateway",
	      "tier":"Regional"
	   },
	   "tags":{
	      
	   }
	}

Response:
{
	     ...
	    "probes": [
	      {
	        "name": "probe-1223",
	        "id": "/subscriptions/xxx/resourceGroups/acctestRG-lb-1222-5/providers/Microsoft.Network/loadBalancers/acctestlb-1222-3/probes/probe-1223",
	        "etag": "W/\"5b43fd7a-3416-4d67-81bd-eb7a86938b03\"",
	        "properties": {
	          "provisioningState": "Updating",
	          "protocol": "Tcp",
	          "port": 20,
	          "intervalInSeconds": 15,
	          "numberOfProbes": 2,
	          "probeThreshold": 1
	        },
	        "type": "Microsoft.Network/loadBalancers/probes"
	      }
	    ],
	    "inboundNatRules": [],
	    "outboundRules": [],
	    "inboundNatPools": []
	  },
	  "sku": {
	    "name": "Gateway",
	    "tier": "Regional"
	  }
}

• Test results in Teamcity:

The above two failing tests have been fixed in the PR.

[stephybun]

Thanks for this @sinbai. Would you mind rebasing this? (due to the changes we made in the go-azure-sdk module structure)

[sinbai]

Thanks for this @sinbai. Would you mind rebasing this? (due to the changes we made in the go-azure-sdk module structure)

Thank you for your reminder @stephybun , already rebased.

[stephybun]

Thanks @sinbai LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.