Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_management_policy - Support properties rule.*.actions.*.base_blob.0.tier_to_cold_after_days_since_{modification|last_access_time|creation}_greater_than and rule.*.actions.*.{snapshot|version}.0.tier_to_cold_after_days_since_creation_greater_than #23574

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Oct 16, 2023

Fix #23020

Test

terraform-provider-azurerm on  storage_mgmt_policy_tier_to_cold via 🐹 v1.21.1 took 4m37s
💢  TF_ACC=1 go test -v -timeout=20h -run='TestAccStorageManagementPolicy_' ./internal/services/storage
=== RUN   TestAccStorageManagementPolicy_basic
=== PAUSE TestAccStorageManagementPolicy_basic
=== RUN   TestAccStorageManagementPolicy_requiresImport
=== PAUSE TestAccStorageManagementPolicy_requiresImport
=== RUN   TestAccStorageManagementPolicy_singleAction
=== PAUSE TestAccStorageManagementPolicy_singleAction
=== RUN   TestAccStorageManagementPolicy_singleActionUpdate
=== PAUSE TestAccStorageManagementPolicy_singleActionUpdate
=== RUN   TestAccStorageManagementPolicy_multipleRule
=== PAUSE TestAccStorageManagementPolicy_multipleRule
=== RUN   TestAccStorageManagementPolicy_updateMultipleRule
=== PAUSE TestAccStorageManagementPolicy_updateMultipleRule
=== RUN   TestAccStorageManagementPolicy_blobTypes
=== PAUSE TestAccStorageManagementPolicy_blobTypes
=== RUN   TestAccStorageManagementPolicy_blobIndexMatch
=== PAUSE TestAccStorageManagementPolicy_blobIndexMatch
=== RUN   TestAccStorageManagementPolicy_complete
=== PAUSE TestAccStorageManagementPolicy_complete
=== RUN   TestAccStorageManagementPolicy_zero
=== PAUSE TestAccStorageManagementPolicy_zero
=== RUN   TestAccStorageManagementPolicy_update
=== PAUSE TestAccStorageManagementPolicy_update
=== RUN   TestAccStorageManagementPolicy_baseblobAccessTimeBased
=== PAUSE TestAccStorageManagementPolicy_baseblobAccessTimeBased
=== CONT  TestAccStorageManagementPolicy_basic
=== CONT  TestAccStorageManagementPolicy_blobTypes
=== CONT  TestAccStorageManagementPolicy_zero
=== CONT  TestAccStorageManagementPolicy_blobIndexMatch
=== CONT  TestAccStorageManagementPolicy_complete
=== CONT  TestAccStorageManagementPolicy_baseblobAccessTimeBased
=== CONT  TestAccStorageManagementPolicy_updateMultipleRule
=== CONT  TestAccStorageManagementPolicy_update
=== CONT  TestAccStorageManagementPolicy_singleAction
=== CONT  TestAccStorageManagementPolicy_multipleRule
=== CONT  TestAccStorageManagementPolicy_singleActionUpdate
=== CONT  TestAccStorageManagementPolicy_requiresImport
--- PASS: TestAccStorageManagementPolicy_complete (83.64s)
--- PASS: TestAccStorageManagementPolicy_basic (83.98s)
--- PASS: TestAccStorageManagementPolicy_blobTypes (84.44s)
--- PASS: TestAccStorageManagementPolicy_singleAction (84.69s)
--- PASS: TestAccStorageManagementPolicy_multipleRule (144.76s)
--- PASS: TestAccStorageManagementPolicy_zero (145.77s)
--- PASS: TestAccStorageManagementPolicy_requiresImport (153.44s)
--- PASS: TestAccStorageManagementPolicy_singleActionUpdate (155.98s)
--- PASS: TestAccStorageManagementPolicy_updateMultipleRule (181.61s)
--- PASS: TestAccStorageManagementPolicy_update (244.14s)
--- PASS: TestAccStorageManagementPolicy_blobIndexMatch (251.86s)
--- PASS: TestAccStorageManagementPolicy_baseblobAccessTimeBased (265.01s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       265.048s

…ons.*.base_blob.0.tier_to_cold_after_days_since_{modification|last_access_time|creation}_greater_than` and `rule.*.actions.*.{snapshot|version}.0.tier_to_cold_after_days_since_creation_greater_than`
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo LGTM!

catriona-m added a commit that referenced this pull request Oct 27, 2023
@catriona-m catriona-m merged commit 48321a4 into hashicorp:main Oct 27, 2023
22 checks passed
@github-actions github-actions bot added this to the v3.79.0 milestone Oct 27, 2023
dduportal referenced this pull request in jenkins-infra/azure Nov 6, 2023
<Actions>
<action
id="f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8">
        <h3>Bump Terraform `azurerm` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>&#34;hashicorp/azurerm&#34; updated from &#34;3.77.0&#34; to
&#34;3.79.0&#34; in file &#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>3.79.0</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.79.0&#xA;ENHANCEMENTS:&#xA;&#xA;*
provider: log instead of error when RPs are unavailable when validating
RP registrations
([#23380](hashicorp/terraform-provider-azurerm#23380
`azurerm_arc_kuberenetes_cluster_extension_resource` - the `version` and
`release_train` properties can now be set simultaneously
([#23692](hashicorp/terraform-provider-azurerm#23692
`azurerm_container_apps` - support for the `ingress.exposed_port`
property
([#23752](hashicorp/terraform-provider-azurerm#23752
`azurerm_cosmosdb_postgresql_cluster` - read replica clusters can be
created without specifying `administrator_login_password` property
([#23750](hashicorp/terraform-provider-azurerm#23750
`azurerm_managed_application` - arrays can be supplied in the
`parameter_values` property
([#23754](hashicorp/terraform-provider-azurerm#23754
`azurerm_storage_management_policy` - support for properties
`rule.*.actions.*.base_blob.0.tier_to_cold_after_days_since_{modification|last_access_time|creation}_greater_than
and
rule.*.actions.*.{snapshot|version}.0.tier_to_cold_after_days_since_creation_greater_than`
([#23574](https://github.com/hashicorp/terraform-provider-azurerm/issues/23574))&#xA;&#xA;BUG
FIXES:&#xA;&#xA;* `azurerm_api_management_diagnostic` - the
`operation_name_format` attribute will only be sent if `identifier` is
set to `applicationinsights`
([#23736](hashicorp/terraform-provider-azurerm#23736
`azurerm_backup_policy_vm` - fix payload by using current datetime
([#23586](hashicorp/terraform-provider-azurerm#23586
`azurerm_kubernetes_cluster` - the `custom_ca_trust_certificates_base64`
property can not be removed, only updated
([#23737](https://github.com/hashicorp/terraform-provider-azurerm/issues/23737))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_storage_management_policy (cold storage policy)
2 participants