azurerm_synapse_workspace: fix panic of slice index out-of-range
#23019
Conversation
There was a problem hiding this comment.
Hi @wuxu92, thank you for opening this PR. While the parsing code would fix the panic mentioned in the issue I think the real fix would be to add a ValidateFunc to the storage_data_lake_gen2_filesystem_id field in the schema. That way if the end users pass in an invalid storage_data_lake_gen2_filesystem_id it would be caught during plan phase of deployment. What do you think?
|
@WodansSon thanks for your review. a validation func added to this field. |
| Type: pluginsdk.TypeString, | ||
| Required: true, | ||
| ForceNew: true, | ||
| ValidateFunc: validation.IsURLWithPath, |
There was a problem hiding this comment.
this is a resource id? should we not be validating it as an id not a uri?
There was a problem hiding this comment.
@katbyte, the ID here is in the form of a URI (e.g., https://storageaccountname.dfs.core.windows.net/filesystemname)
|
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Not sure why need a
uri.Path[1:]here, I guess it want to trim the leading slash (by the comment inline), so change to usestrings.TrimPrefixfixes: #23004