including #23019 fixes #23004

* fix panic of path slice index

* add a validation for storage_data_lake_gen2_filesystem_id

internal/services/synapse/synapse_workspace_resource.go

@@ -68,9 +68,10 @@ func resourceSynapseWorkspace() *pluginsdk.Resource {
 			"location": commonschema.Location(),
 
 			"storage_data_lake_gen2_filesystem_id": {
-				Type:     pluginsdk.TypeString,
-				Required: true,
-				ForceNew: true,
+				Type:         pluginsdk.TypeString,
+				Required:     true,
+				ForceNew:     true,
+				ValidateFunc: validation.IsURLWithPath,
 			},
 
 			"sql_administrator_login": {
@@ -795,7 +796,7 @@ func expandArmWorkspaceDataLakeStorageAccountDetails(storageDataLakeGen2Filesyst
 	uri, _ := url.Parse(storageDataLakeGen2FilesystemId)
 	return &synapse.DataLakeStorageAccountDetails{
 		AccountURL: utils.String(fmt.Sprintf("%s://%s", uri.Scheme, uri.Host)), // https://storageaccountname.dfs.core.windows.net/filesystemname -> https://storageaccountname.dfs.core.windows.net
-		Filesystem: utils.String(uri.Path[1:]),                                 // https://storageaccountname.dfs.core.windows.net/filesystemname -> filesystemname
+		Filesystem: utils.String(strings.TrimPrefix(uri.Path, "/")),            // https://storageaccountname.dfs.core.windows.net/filesystemname -> filesystemname
 	}
 }
 

internal/tf/validation/pluginsdk.go

@@ -5,7 +5,9 @@ package validation
 
 import (
 	"fmt"
+	"net/url"
 	"regexp"
+	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
@@ -171,6 +173,33 @@ func IsURLWithScheme(validSchemes []string) func(interface{}, string) ([]string,
 	return validation.IsURLWithScheme(validSchemes)
 }
 
+// IsURLWithPath is a SchemaValidateFunc that tests if the provided value is of type string and a valid URL with a path
+func IsURLWithPath(i interface{}, k string) (_ []string, errors []error) {
+	v, ok := i.(string)
+	if !ok {
+		errors = append(errors, fmt.Errorf("expected type of %q to be string", k))
+		return
+	}
+
+	if v == "" {
+		errors = append(errors, fmt.Errorf("expected %q url to not be empty, got %v", k, i))
+		return
+	}
+
+	u, err := url.Parse(v)
+	if err != nil {
+		errors = append(errors, fmt.Errorf("expected %q to be a valid url, got %v: %+v", k, v, err))
+		return
+	}
+
+	if strings.TrimPrefix(u.Path, "/") == "" {
+		errors = append(errors, fmt.Errorf("expected %q to have a non empty path got %v", k, v))
+		return
+	}
+
+	return
+}
+
 // IsUUID is a ValidateFunc that ensures a string can be parsed as UUID
 func IsUUID(i interface{}, k string) ([]string, []error) {
 	return validation.IsUUID(i, k)