-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automat_dsc_configuration
: update sdk to 2022-08-08
#22403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @wuxu92
Thanks for this PR - taking a look through here it appears that we're going to want to split the changes in this PR though:
hashicorp/go-azure-sdk
tends to be updated regularly, as such can we split the SDK upgrade out of this PR?- We'll need to remove the new fields which aren't returned from the API - and open an API tracking that, a field needs to be returned from the API for us to support it in Terraform, else this breaks
import
support - so we'll need that fixed before we can re-introduce those.
However if we can make those changes then this should otherwise be good to go 👍
Thanks!
internal/services/automation/automation_dsc_configuration_resource_test.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_dsc_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_dsc_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_dsc_configuration_resource.go
Outdated
Show resolved
Hide resolved
internal/services/automation/automation_dsc_configuration_resource.go
Outdated
Show resolved
Hide resolved
automat_dsc_configuration
: update sdk to 2022-08-08
and support log_progress
, hash
, source_version
automat_dsc_configuration
: update sdk to 2022-08-08
@tombuildsstuff thanks! the go-azure-sdk PR in #22404 . This PR is to only update the dscconfiguration to 2022-08-08, new fields logic removed and the API issue tracked by Azure/azure-rest-api-specs#24728 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment around adding back in the Import
check for the Complete
test (which I'm going to push a commit for) but this otherwise LGTM - thanks for making those changes @wuxu92
internal/services/automation/automation_dsc_configuration_resource_test.go
Outdated
Show resolved
Hide resolved
34ffadc
to
4fc884b
Compare
(rebased this atop of |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
based on #22404
update to the new base-layered sdk wil fix below acc tests (because of old sdk cannot process literal string reponse body):
Test Result: