`azurerm_site_recovery_replication_recovery_plan`: keep the order of `recovery_group` #22348

ziyeqf · 2023-07-03T05:10:31Z

…`recovery_group` Signed-off-by: ziyeqf <[email protected]>

Signed-off-by: ziyeqf <[email protected]>

tombuildsstuff · 2023-07-03T11:23:00Z

website/docs/r/site_recovery_replication_recovery_plan.html.markdown

@@ -258,6 +261,8 @@ A `recovery_group` block supports the following:

 * `type` - (Required) The Recovery Plan Group Type. Possible values are `Boot`, `Failover` and `Shutdown`.

+**Note:** The List of `recovery_group` must be in the order of `Shutdown`-`Failover`-`Boot`.


should these be modelled differently to account for that?

have updated per comments, please take another look:)

Signed-off-by: ziyeqf <[email protected]>

ziyeqf · 2023-07-04T03:55:43Z

triggered a test on TC and will upload the result here

Signed-off-by: ziyeqf <[email protected]>

ziyeqf · 2023-07-05T01:56:10Z

the schema lint is failing because the new schema has the following

Required: features.FourPointOhBeta(),
Optional: !features.FourPointOhBeta(),
Computed: !features.FourPointOhBeta(),

Can we ignore the failure?

horvatal · 2023-07-05T15:01:04Z

website/docs/r/site_recovery_replication_recovery_plan.html.markdown

+
+-> **NOTE:** `shutdown_recovery_group` will be required in the next major version of the AzureRM Provider.
+
+* `failover_recovery_group` - (Optional) One or more `failover_recovery_group` block defined as below.


This is not consistent with the Microsoft.RecoveryServices/vaults/replicationRecoveryPlans@2022-10-01 API. If I create multiple failover or shutdown groups, I receive an error: "recommendedAction": "Ensure there is only a single shutdown and a single failover group and that virtual machines are present in only one boot group." Only multiple boot groups are allowed.

Thanks, code updated

Signed-off-by: ziyeqf <[email protected]>

manicminer

@ziyeqf Can you look at the linting error? Unfortunately we can't merge a fixable failure.

Signed-off-by: ziyeqf <[email protected]>

manicminer

Thanks @ziyeqf, just some minor wording tweaks but this otherwise LGTM! 🪐

internal/services/recoveryservices/site_recovery_replication_recovery_plan_resource.go

website/docs/r/site_recovery_replication_recovery_plan.html.markdown

github-actions · 2024-05-02T02:08:12Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/recovery-services size/L labels Jul 3, 2023

azurerm_site_recovery_replication_recovery_plan: keep the order of …

3411bab

…`recovery_group` Signed-off-by: ziyeqf <[email protected]>

ziyeqf force-pushed the tengzh/issue/recoveryplan_group_order branch from b630242 to 3411bab Compare July 3, 2023 05:12

ziyeqf mentioned this pull request Jul 3, 2023

azurerm_site_recovery_replication_recovery_plan does not keep order of boot groups #22323

Closed

1 task

update testcase

59e4679

Signed-off-by: ziyeqf <[email protected]>

ziyeqf marked this pull request as ready for review July 3, 2023 09:32

tombuildsstuff reviewed Jul 3, 2023

View reviewed changes

github-actions bot added the waiting-response label Jul 3, 2023

update per comments

50bd332

Signed-off-by: ziyeqf <[email protected]>

github-actions bot removed the waiting-response label Jul 4, 2023

github-actions bot added size/XL and removed size/L labels Jul 4, 2023

ziyeqf added 2 commits July 4, 2023 13:35

update code

a5269ff

Signed-off-by: ziyeqf <[email protected]>

golint

14772ce

Signed-off-by: ziyeqf <[email protected]>

ziyeqf force-pushed the tengzh/issue/recoveryplan_group_order branch from e95a168 to d858643 Compare July 4, 2023 07:20

jackofallops added the waiting-response label Jul 4, 2023

github-actions bot removed the waiting-response label Jul 4, 2023

update testcase

aa0b8f1

Signed-off-by: ziyeqf <[email protected]>

ziyeqf force-pushed the tengzh/issue/recoveryplan_group_order branch from 36ccc7a to aa0b8f1 Compare July 4, 2023 11:15

horvatal reviewed Jul 5, 2023

View reviewed changes

ziyeqf added 2 commits July 6, 2023 09:58

limit shutdown_recovery_group and failover_recovery_group to 1

d890c13

Signed-off-by: ziyeqf <[email protected]>

update code

40b5a24

Signed-off-by: ziyeqf <[email protected]>

ziyeqf mentioned this pull request Jul 7, 2023

azurerm_site_recovery_replication_recovery_plan resorts recovery_groups on every run although there are no changes #22258

Closed

1 task

ziyeqf force-pushed the tengzh/issue/recoveryplan_group_order branch from 431e293 to 40b5a24 Compare July 7, 2023 02:17

golint

caebbf8

Signed-off-by: ziyeqf <[email protected]>

manicminer suggested changes Jul 19, 2023

View reviewed changes

github-actions bot added the waiting-response label Jul 19, 2023

lint

f82f6df

Signed-off-by: ziyeqf <[email protected]>

github-actions bot removed the waiting-response label Jul 20, 2023

manicminer approved these changes Jul 20, 2023

View reviewed changes

Document wording tweaks

964290a

manicminer added this to the v3.66.0 milestone Jul 20, 2023

manicminer merged commit 44d26c6 into hashicorp:main Jul 20, 2023

manicminer added a commit that referenced this pull request Jul 20, 2023

Changelog for #22348

ff30d33

ziyeqf deleted the tengzh/issue/recoveryplan_group_order branch December 20, 2023 08:09

github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_site_recovery_replication_recovery_plan`: keep the order of `recovery_group` #22348

`azurerm_site_recovery_replication_recovery_plan`: keep the order of `recovery_group` #22348

ziyeqf commented Jul 3, 2023 •

edited

Loading

tombuildsstuff Jul 3, 2023

ziyeqf Jul 17, 2023

ziyeqf commented Jul 4, 2023

ziyeqf commented Jul 5, 2023

horvatal Jul 5, 2023 •

edited

Loading

ziyeqf Jul 6, 2023

manicminer left a comment •

edited

Loading

manicminer left a comment •

edited

Loading

github-actions bot commented May 2, 2024

		@@ -258,6 +261,8 @@ A `recovery_group` block supports the following:

		* `type` - (Required) The Recovery Plan Group Type. Possible values are `Boot`, `Failover` and `Shutdown`.

		Note: The List of `recovery_group` must be in the order of `Shutdown`-`Failover`-`Boot`.


		-> NOTE: `shutdown_recovery_group` will be required in the next major version of the AzureRM Provider.

		* `failover_recovery_group` - (Optional) One or more `failover_recovery_group` block defined as below.

azurerm_site_recovery_replication_recovery_plan: keep the order of recovery_group #22348

azurerm_site_recovery_replication_recovery_plan: keep the order of recovery_group #22348

Conversation

ziyeqf commented Jul 3, 2023 • edited Loading

tombuildsstuff Jul 3, 2023

Choose a reason for hiding this comment

ziyeqf Jul 17, 2023

Choose a reason for hiding this comment

ziyeqf commented Jul 4, 2023

ziyeqf commented Jul 5, 2023

horvatal Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

ziyeqf Jul 6, 2023

Choose a reason for hiding this comment

manicminer left a comment • edited Loading

Choose a reason for hiding this comment

manicminer left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented May 2, 2024

`azurerm_site_recovery_replication_recovery_plan`: keep the order of `recovery_group` #22348

`azurerm_site_recovery_replication_recovery_plan`: keep the order of `recovery_group` #22348

ziyeqf commented Jul 3, 2023 •

edited

Loading

horvatal Jul 5, 2023 •

edited

Loading

manicminer left a comment •

edited

Loading

manicminer left a comment •

edited

Loading