Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source azurerm_network_manager_network_group #22277

Merged
merged 3 commits into from
Jun 28, 2023
Merged

New Data Source azurerm_network_manager_network_group #22277

merged 3 commits into from
Jun 28, 2023

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Jun 25, 2023 •
edited
Loading

resolves #21297

image

stephybun
stephybun requested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa. Couple of minor comments otherwise this is looking good.

internal/services/network/network_manager_network_group_data_source.go Outdated Show resolved Hide resolved
website/docs/d/network_manager_network_group.html.markdown Show resolved Hide resolved
website/docs/d/network_manager_network_group.html.markdown Outdated Show resolved Hide resolved
stephybun
stephybun approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @teowa LGTM 👍

@stephybun stephybun merged commit 2518162 into hashicorp:main Jun 28, 2023
@github-actions github-actions bot added this to the v3.63.0 milestone Jun 28, 2023
stephybun added a commit that referenced this pull request Jun 28, 2023
@stephybun
Update for #22277, #22284, #22012, #21760
85d61bc
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation new-data-source service/network size/L
Projects
None yet
Milestone
v3.63.0
Development

Successfully merging this pull request may close these issues.

Data source for "azurerm_network_manager_network_group" resource
2 participants
@teowa @stephybun