Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update managed disk docs with correct sizes & add Ultra SSD type #2118

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Oct 19, 2018

also removed import tests & tidied tests

Fixes #2115

@katbyte katbyte added this to the 1.17.1 milestone Oct 19, 2018
@katbyte katbyte requested a review from a team October 19, 2018 22:39
@ghost ghost added the size/L label Oct 19, 2018
@katbyte katbyte force-pushed the d/managed_disk-type branch from 5ff3997 to 3359cde Compare October 19, 2018 22:41
@katbyte katbyte changed the title Update managed disk docs with correct size types Update managed disk docs with correct size types & add Ultra SSD type Oct 19, 2018
@katbyte katbyte added the bug label Oct 19, 2018
@katbyte katbyte changed the title Update managed disk docs with correct size types & add Ultra SSD type Update managed disk docs with correct sizes & add Ultra SSD type Oct 19, 2018
@katbyte katbyte force-pushed the d/managed_disk-type branch 4 times, most recently from f4df890 to 88d2f3f Compare October 19, 2018 23:40
@katbyte katbyte force-pushed the d/managed_disk-type branch from 88d2f3f to 77ba503 Compare October 19, 2018 23:52
@katbyte
Copy link
Collaborator Author

katbyte commented Oct 20, 2018

tests pass:

gofmt -w $(find . -name '*.go' |grep -v vendor)
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azurerm -v -test.run=TestAccAzureRMManagedDisk -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMManagedDisk_empty
--- PASS: TestAccAzureRMManagedDisk_empty (72.24s)
=== RUN   TestAccAzureRMManagedDisk_zeroGbFromPlatformImage
--- PASS: TestAccAzureRMManagedDisk_zeroGbFromPlatformImage (77.49s)
=== RUN   TestAccAzureRMManagedDisk_import
--- PASS: TestAccAzureRMManagedDisk_import (401.24s)
=== RUN   TestAccAzureRMManagedDisk_copy
--- PASS: TestAccAzureRMManagedDisk_copy (131.90s)
=== RUN   TestAccAzureRMManagedDisk_fromPlatformImage


--- PASS: TestAccAzureRMManagedDisk_fromPlatformImage (79.70s)
=== RUN   TestAccAzureRMManagedDisk_update
--- PASS: TestAccAzureRMManagedDisk_update (80.76s)
=== RUN   TestAccAzureRMManagedDisk_encryption
--- PASS: TestAccAzureRMManagedDisk_encryption (218.39s)
=== RUN   TestAccAzureRMManagedDisk_NonStandardCasing
--- PASS: TestAccAzureRMManagedDisk_NonStandardCasing (79.30s)
=== RUN   TestAccAzureRMManagedDisk_importEmpty_withZone
--- PASS: TestAccAzureRMManagedDisk_importEmpty_withZone (69.74s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	1210.794s

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katbyte LGTM

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit f34b3c0 into master Oct 30, 2018
@tombuildsstuff tombuildsstuff deleted the d/managed_disk-type branch October 30, 2018 09:53
tombuildsstuff added a commit that referenced this pull request Oct 30, 2018
tombuildsstuff added a commit that referenced this pull request Oct 30, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants