azurerm_subscription - Replace Track1 with Pandora SDK
#18813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristosvo
force-pushed
the
subscription/pandora-sdk
branch
from
9790685 to
5b9cd52
Compare
aristosvo
force-pushed
the
subscription/pandora-sdk
branch
from
3405059 to
5fa2c3d
Compare
1 task
manicminer
suggested changes
Nov 10, 2022
There was a problem hiding this comment.
Hi @aristosvo, this looks great and the tests are passing. I have reservations about adding the management_group_id property here though, more details inline. If you can take a look then this should be good to merge. Thanks!
aristosvo
force-pushed
the
subscription/pandora-sdk
branch
from
5fa2c3d to
03af4b0
Compare
|
Rebased and management group removed |
aristosvo
force-pushed
the
subscription/pandora-sdk
branch
from
f21adf7 to
3767ff2
Compare
manicminer
force-pushed
the
subscription/pandora-sdk
branch
from
3767ff2 to
3369bb7
Compare
github-actions
bot
added
documentation
service/api-management
service/mssql
jackofallops
force-pushed
the
subscription/pandora-sdk
branch
from
5e63a8b to
972b6cd
Compare
github-actions
bot
removed
service/mssql
|
Hi @aristosvo - Hope you don't mind, I'm digging into an API permissions issue on this resource and I've pushed a few changes. I may need to do more depending on the outcome of the investigation. For context, permissions that allow a user to create subscriptions in the Portal are insufficient via the API. (at least for MCAs) As soon as that's resolved, and we can test this works as expected, we can get it merged. |
|
Tested manually:
|
|
This functionality has been released in v3.50.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Acceptance Tests is kind of impossible for me at the moment as I don't have an EA account which I can play with a bit more.