Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Databricks Access Connector #18518

Closed
1 task done
nkuln opened this issue Sep 23, 2022 · 3 comments · Fixed by #18709
Closed
1 task done

Support for Databricks Access Connector #18518

nkuln opened this issue Sep 23, 2022 · 3 comments · Fixed by #18709
Assignees
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/databricks
Milestone

Comments

@nkuln
Copy link

nkuln commented Sep 23, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Want to explore what is the work required to support Databricks Access Connector natively from azurerm

Currently, because the resource is not available from azurerm, we have to manage it through azapi.

resource "azapi_resource" "ext_access_connector" {
  type      = "Microsoft.Databricks/accessConnectors@2022-04-01-preview"
  name      = "ext-databricks-mi"
  location  = data.azurerm_resource_group.this.location
  parent_id = data.azurerm_resource_group.this.id
  identity {
    type = "SystemAssigned"
  }
  body = jsonencode({
    properties = {}
  })
}

New or Affected Resource(s)/Data Source(s)

azurerm_databricks_?

Potential Terraform Configuration

No response

References

No response

@favoretti
Copy link
Collaborator

@tombuildsstuff can we generate the SDK please? I can work on implementing this in provider.

@favoretti favoretti self-assigned this Sep 25, 2022
@favoretti favoretti added service/databricks enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used labels Sep 25, 2022
favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Oct 12, 2022
Also upgrade Databricks SDK to `2022-04-01-preview`
I added acceptance tests, but feature is in private preview.

Fixes hashicorp#18518
favoretti added a commit to favoretti/terraform-provider-azurerm that referenced this issue Oct 13, 2022
Also upgrade Databricks SDK to `2022-04-01-preview`
I added acceptance tests, but feature is in private preview.

Fixes hashicorp#18518
stephybun added a commit that referenced this issue Oct 14, 2022
* New resource: `azurerm_databricks_access_connector`

Also upgrade Databricks SDK to `2022-04-01-preview`
I added acceptance tests, but feature is in private preview.

Fixes #18518

* Fix a typo in docs

* Fix unit tests

* Rewrite as a typed resource

* Identity and registration fixes

* Identity and registration fixes

* Update internal/services/databricks/databricks_access_connector_resource.go

Co-authored-by: stephybun <[email protected]>

* Update internal/services/databricks/databricks_access_connector_resource.go

Co-authored-by: stephybun <[email protected]>

* Update internal/services/databricks/databricks_access_connector_resource.go

Co-authored-by: stephybun <[email protected]>

* Update internal/services/databricks/databricks_access_connector_resource.go

Co-authored-by: stephybun <[email protected]>

Co-authored-by: stephybun <[email protected]>
@github-actions github-actions bot added this to the v3.28.0 milestone Oct 14, 2022
@github-actions
Copy link

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement sdk/requires-newer-api-version This requires upgrading the version of the API being used service/databricks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants