Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventhub_namespace: update public_network_access settings #18314

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Sep 9, 2022

Fix:#18054

There are two places to set public_network_access for an eventhub namespace. If the values are different, one overrides the other. For example, if the public network access is turned off at the namespace level, while is turned on in the network rulesets block. The namespace setting will be override.

@github-actions github-actions bot added the service/event-hubs EventHubs label Sep 9, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ♻️

@katbyte katbyte merged commit 3b680ed into hashicorp:main Sep 13, 2022
katbyte added a commit that referenced this pull request Sep 13, 2022
@github-actions github-actions bot added this to the v3.23.0 milestone Sep 13, 2022
@github-actions
Copy link

This functionality has been released in v3.23.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants