-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_eventhub_namespace public_network_access_enabled doesn't working properly when network_rulesets block exists #18054
Comments
Is there any progress regarding this bug? |
Any help please? |
Thanks @omerfeldman2 , does the override works the same via azure portal, the public_network_access value will also be override if you are setting the same config in the portal? |
If you deploy it with arm template the network_rulesets public_network_access_enabled attribute override the the regular public_network_access_enabled, unfortunately terraform doesn’t support to modify the override attribute and it default to true. Which means every time network_rulesets block is defined the event hub namespace will be created with public access. |
If I set |
{ This is the arm template of network_rulesets block |
Thanks @omerfeldman2 , let me check the api and source code, will update once confirmed. |
Thanks, I really appreciate that. |
Hi @omerfeldman2 , I've added the override property in the mentioned pr. I have restricted the value setting, the public network access setting in two places has to be the same, otherwise, there will be an error. You can track the status in the pr. Feel free to let me know if there is anything needed. |
Thanks a lot!! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Is there an existing issue for this?
Community Note
Terraform Version
1.1.5
AzureRM Provider Version
3.17.0
Affected Resource(s)/Data Source(s)
azurerm_eventhub_namespace
Terraform Configuration Files
Debug Output/Panic Output
Expected Behaviour
eventhub namespace should be created with public access enabled fals
e
Actual Behaviour
eventhub namespace created with public access enabled tru
e
and when i rerun terraform apply without code changes:
Steps to Reproduce
terraform apply
Important Factoids
No response
References
No response
NOTE:
As i noticed the real problem is when you use the network_rulesets block, in the rulesets block there is also public_network_access_enabled attribute which is defaults to true.
therefore when you use the rulesets block the public_network_access_enabled attribute overrides the entered attribute.
The text was updated successfully, but these errors were encountered: