Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_container_registry does not support virtual_network anymore #18232

Closed
1 task done
chaoqi opened this issue Sep 2, 2022 · 4 comments · Fixed by #18239
Closed
1 task done

azurerm_container_registry does not support virtual_network anymore #18232

chaoqi opened this issue Sep 2, 2022 · 4 comments · Fixed by #18239

Comments

@chaoqi
Copy link

chaoqi commented Sep 2, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

1.2.8

AzureRM Provider Version

3.21.0

Affected Resource(s)/Data Source(s)

3.21.0

Terraform Configuration Files

virtual_network block seems being removed from the network_rule_set... is there any resources to use instead?

Debug Output/Panic Output

Error: Unsupported argument

  on ../../../../products/container-registry/terraform/acr.tf line 31, in resource "azurerm_container_registry" "acr":
  31:     virtual_network = length(var.networkACLs.subnetIds) > 0 ? [

An argument named "virtual_network" is not expected here.

Expected Behaviour

Terraform should not break---

Actual Behaviour

terraform breaks

Steps to Reproduce

No response

Important Factoids

No response

References

No response

@chaoqi chaoqi added the bug label Sep 2, 2022
@github-actions github-actions bot removed the bug label Sep 2, 2022
@chaoqi
Copy link
Author

chaoqi commented Sep 2, 2022

it looks like this part of code is getting deleted via this PR: #17926

@katbyte
Copy link
Collaborator

katbyte commented Sep 2, 2022

Hey @chaoqi, really sorry that i missed this in my review of #17926, i've opened #18239 that backs out those changes - this will be released as part of a patch release later today

katbyte added a commit that referenced this issue Sep 2, 2022
…ew properties" (#18239)

Reverts #17926 due to it removing properties. unfortunately I don't see an easy way to keep both the new properties and the old block so reverting to unblock existing users and restore expected functionality.

fixes #18232
@github-actions github-actions bot added this to the v3.22.0 milestone Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v3.22.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.