Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_network_gateway_connection - support egress_nat_rule_ids and ingress_nat_rule_ids #16862

Merged
merged 3 commits into from
May 26, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented May 19, 2022

fixes #15348

As the PR 15720 has been merged, so submitted this PR to support egress_nat_rule_ids and ingress_nat_rule_ids to resolve above issue.

--- PASS: TestAccVirtualNetworkGatewayConnection_ipsecpolicy (2091.68s)
--- PASS: TestAccVirtualNetworkGatewayConnection_connectionprotocol (2106.24s)
--- PASS: TestAccVirtualNetworkGatewayConnection_trafficSelectorPolicyMultiple (2298.72s)
--- PASS: TestAccVirtualNetworkGatewayConnection_ConnectionMode (2310.68s)
--- PASS: TestAccVirtualNetworkGatewayConnection_trafficSelectorPolicy (2412.86s)
--- PASS: TestAccVirtualNetworkGatewayConnection_useCustomBgpAddresses (2428.05s)
--- PASS: TestAccVirtualNetworkGatewayConnection_sitetositeWithoutSharedKey (2966.99s)
--- PASS: TestAccVirtualNetworkGatewayConnection_sitetosite (3019.70s)
--- PASS: TestAccVirtualNetworkGatewayConnection_updatingSharedKey (3111.74s)
--- PASS: TestAccVirtualNetworkGatewayConnection_vnettonet (3182.60s)
--- PASS: TestAccVirtualNetworkGatewayConnection_natRuleIds (2998.92s)
--- PASS: TestAccVirtualNetworkGatewayConnection_requiresImport (3241.15s)
--- PASS: TestAccVirtualNetworkGatewayConnection_useLocalAzureIpAddressEnabled (5098.20s)

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@katbyte katbyte merged commit e49f672 into hashicorp:main May 26, 2022
@github-actions github-actions bot added this to the v3.8.0 milestone May 26, 2022
katbyte added a commit that referenced this pull request May 26, 2022
@github-actions
Copy link

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azurerm_virtual_network_gateway_nat_rule
2 participants