Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for azurerm_virtual_network_gateway_nat_rule #15348

Closed
daniel-anova opened this issue Feb 9, 2022 · 1 comment · Fixed by #16862
Closed

Support for azurerm_virtual_network_gateway_nat_rule #15348

daniel-anova opened this issue Feb 9, 2022 · 1 comment · Fixed by #16862

Comments

@daniel-anova
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

VPN Gateway resource has NAT Rules in Preview, this feature request is to add a new resource to create nat rules as well as an associative resource to link a nat rule to a connection.

It's probably best the resource mimics the equivalent Virtual WAN resource azurerm_vpn_gateway_nat_rule as closely as possible.

Additionally currently, adding NAT rules through the portals to a azurerm_virtual_network_gateway makes following applies to fail do to existing NAT rules.

New or Affected Resource(s)

  • azurerm_virtual_network_gateway
  • azurerm_virtual_network_gateway_connection

Potential Terraform Configuration

resource "azurerm_virtual_private_network_gateway_nat_rule" "example" {
  name                            = "example-vpngatewaynatrule"
  resource_group_name             = azurerm_resource_group.example.name
  virtual_network_gateway_id      = azurerm_virtual_network_gateway.example.id
  external_address_space_mappings = ["192.168.21.0/26"]
  internal_address_space_mappings = ["10.4.0.0/26"]
}

resource "azurerm_vpn_gateway_nat_rule_association" "example" {
  virtual_network_gateway_id    = azurerm_virtual_network_gateway.example.id
  virtual_network_connection_id = azurerm_virtual_network_gateway_connection.example.id
}

References

katbyte pushed a commit that referenced this issue May 18, 2022
To resolve the issue #15348, it has to implement Virtual Network Gateway Nat Rule first. Once this PR is merged, I assume it has to submit another PR to implement egressNatRules and ingressNatRules of Virtual Network Gateway Connection (azurerm_virtual_network_gateway_connection).
katbyte pushed a commit that referenced this issue May 26, 2022
…ids and ingress_nat_rule_ids (#16862)

fixes #15348

As the PR 15720 has been merged, so submitted this PR to support egress_nat_rule_ids and ingress_nat_rule_ids to resolve above issue.
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants