Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for mysql_flexible_server.backup_retention_days < 7 #16311

Closed
1 task done
kratkyzobak opened this issue Apr 10, 2022 · 2 comments
Closed
1 task done

Support for mysql_flexible_server.backup_retention_days < 7 #16311

kratkyzobak opened this issue Apr 10, 2022 · 2 comments

Comments

@kratkyzobak
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

In https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/mysql_flexible_server#backup_retention_days, there is 7 as minimum. According to Azure documentation (and according to setting enabled through portal), minimum is one day.

I hope, 7 were used as resource were copied from PosgtreSQL version of Flexible server, where 7 days is minimum.

New or Affected Resource(s)/Data Source(s)

azurerm_mysql_flexible_server

Potential Terraform Configuration

azurerm_mysql_flexible_server {
  ...
  backup_retention_days = 1
  ...
}

References

kratkyzobak added a commit to kratkyzobak/terraform-provider-azurerm that referenced this issue Apr 10, 2022
kratkyzobak added a commit to kratkyzobak/terraform-provider-azurerm that referenced this issue Apr 10, 2022
catriona-m pushed a commit that referenced this issue Apr 12, 2022
* Fix validator of backup_retention_days

#16311

* Fix documentation of backup_retention_days

#16311
@mbfrahry
Copy link
Member

mbfrahry commented May 2, 2022

Hey @kratkyzobak, it looks like this doc change went in a couple weeks ago. I'm going to close this issue down but feel free to reopen it if you're still seeing issues

@mbfrahry mbfrahry closed this as completed May 2, 2022
@mbfrahry mbfrahry added this to the v3.2.0 milestone May 2, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants